From mboxrd@z Thu Jan  1 00:00:00 1970
Message-ID: <47053A58.8000705@manicmethod.com>
Date: Thu, 04 Oct 2007 15:09:12 -0400
From: Joshua Brindle <method@manicmethod.com>
MIME-Version: 1.0
To: Eamon Walsh <ewalsh@tycho.nsa.gov>
CC: SELinux List <selinux@tycho.nsa.gov>, Stephen Smalley <sds@tycho.nsa.gov>
Subject: Re: [PATCH 3/3] libselinux: minor updates to AVC, mapping, callbacks
References: <47041CB6.8070408@tycho.nsa.gov> <47052C83.3020703@tycho.nsa.gov>
In-Reply-To: <47052C83.3020703@tycho.nsa.gov>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Sender: owner-selinux@tycho.nsa.gov
List-Id: selinux@tycho.nsa.gov

Eamon Walsh wrote:
> This patch allows empty strings to be specified as permissions in
> the dynamic permission mapping.  An empty string will be interpreted
> as a "skipped bit" which allows userspace object managers to use
> non-contiguous permission bits.
>

Why is this necessary?

> Signed-off-by: Eamon Walsh <ewalsh@tycho.nsa.gov>
> ---
>
> mapping.c |    6 ++++++
> 1 file changed, 6 insertions(+)
>
>
> Index: libselinux/src/mapping.c
> ===================================================================
> --- libselinux/src/mapping.c    (revision 2628)
> +++ libselinux/src/mapping.c    (working copy)
> @@ -68,6 +68,11 @@
>
>         k = 0;
>         while (p_in->perms && p_in->perms[k]) {
> +            /* An empty permission string skips ahead */
> +            if (!*p_in->perms[k]) {
> +                k++;
> +                continue;
> +            }
>             p_out->perms[k] = string_to_av_perm(p_out->value,
>                                 p_in->perms[k]);
>             if (!p_out->perms[k])
> @@ -111,6 +116,7 @@
>
>         for (i=0; i<current_mapping[tclass].num_perms; i++)
>             if (tperm & (1<<i)) {
> +                assert(current_mapping[tclass].perms[i]);
>                 kperm |= current_mapping[tclass].perms[i];
>                 tperm &= ~(1<<i);
>             }
>
>
>



--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.