From: Tony Battersby <tonyb@cybernetics.com>
To: netdev@vger.kernel.org, davem@davemloft.net
Subject: [PATCH] net: fix kernel_accept() error path
Date: Thu, 04 Oct 2007 16:20:05 -0400 [thread overview]
Message-ID: <47054AF5.4050409@cybernetics.com> (raw)
If accept() returns an error, kernel_accept() releases the new socket
but passes a pointer to the released socket back to the caller. Make it
pass back NULL instead.
Signed-off-by: Tony Battersby <tonyb@cybernetics.com>
---
--- linux-2.6.23-rc9/net/socket.c.bak 2007-10-04 15:21:17.000000000 -0400
+++ linux-2.6.23-rc9/net/socket.c 2007-10-04 15:21:22.000000000 -0400
@@ -2230,6 +2230,7 @@ int kernel_accept(struct socket *sock, s
err = sock->ops->accept(sock, *newsock, flags);
if (err < 0) {
sock_release(*newsock);
+ *newsock = NULL;
goto done;
}
next reply other threads:[~2007-10-04 20:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-04 20:20 Tony Battersby [this message]
2007-10-04 21:57 ` [PATCH] net: fix kernel_accept() error path James Morris
2007-10-04 22:08 ` David Miller
2007-10-04 22:12 ` Tony Battersby
2007-10-04 23:55 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47054AF5.4050409@cybernetics.com \
--to=tonyb@cybernetics.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.