From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yosuke Iwamatsu Subject: [PATCH] Xentrace: Avoid Crash on Debug Build Xen Date: Fri, 05 Oct 2007 10:54:28 +0900 Message-ID: <47059954.8010009@ab.jp.nec.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------020407000901070000090501" Return-path: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org This is a multi-part message in MIME format. --------------020407000901070000090501 Content-Type: text/plain; charset=ISO-2022-JP Content-Transfer-Encoding: 7bit Hi there, Current xen-unstable (debug build) crashes when using xentrace command, due to assertion failures. It seems assertion failures occur whenever there exist lost records, and I don't see much reason to do this. (Could anyone explain about these ASSERT lines ?) The attached patch removes assertions to avoid system crashes, and also fixes a mistake of an assignment statement. Regards, ------------------- Yosuke Iwamatsu NEC Corporation --------------020407000901070000090501 Content-Type: text/plain; name="xentrace_remove_assert.patch" Content-Transfer-Encoding: base64 Content-Disposition: inline; filename="xentrace_remove_assert.patch" WGVudHJhY2U6IFJlbW92ZSBhc3NlcnRpb25zIHRvIGF2b2lkIHN5c3RlbSBjcmFzaGVzIG9u IGRlYnVnIGJ1aWxkIHhlbi4KClNpZ25lZC1vZmYtYnk6IFlvc3VrZSBJd2FtYXRzdSA8eS1p d2FtYXRzdUBhYi5qcC5uZWMuY29tPgoKZGlmZiAtciAyZDc2MWNhNzcxZmIgeGVuL2NvbW1v bi90cmFjZS5jCi0tLSBhL3hlbi9jb21tb24vdHJhY2UuYwlUaHUgT2N0IDA0IDE3OjU4OjE2 IDIwMDcgKzAxMDAKKysrIGIveGVuL2NvbW1vbi90cmFjZS5jCUZyaSBPY3QgMDUgMTA6Mjg6 MzMgMjAwNyArMDkwMApAQCAtNDM1LDEyICs0MzUsMTAgQEAgdm9pZCBfX3RyYWNlX3Zhcih1 MzIgZXZlbnQsIGludCBjeWNsZXMsIAogICAgICAgICB7CiAgICAgICAgICAgICBieXRlc190 b193cmFwIC09IExPU1RfUkVDX1NJWkU7CiAgICAgICAgICAgICBpZiAoIGJ5dGVzX3RvX3dy YXAgPT0gMCApCi0gICAgICAgICAgICAgICAgYnl0ZXNfdG9fd3JhcCA9PSBkYXRhX3NpemU7 CisgICAgICAgICAgICAgICAgYnl0ZXNfdG9fd3JhcCA9IGRhdGFfc2l6ZTsKICAgICAgICAg fQogICAgICAgICB0b3RhbF9zaXplICs9IExPU1RfUkVDX1NJWkU7CiAgICAgfQotCi0gICAg QVNTRVJUKGJ5dGVzX3RvX3dyYXAgPT0gY2FsY19ieXRlc190b193cmFwKGJ1ZikpOwogCiAg ICAgaWYgKCByZWNfc2l6ZSA+IGJ5dGVzX3RvX3dyYXAgKQogICAgIHsKQEAgLTQ4NCw4ICs0 ODIsNiBAQCB2b2lkIF9fdHJhY2VfdmFyKHUzMiBldmVudCwgaW50IGN5Y2xlcywgCiAgICAg ICAgIGluc2VydF9sb3N0X3JlY29yZHMoYnVmKTsKICAgICB9CiAKLSAgICBBU1NFUlQoYnl0 ZXNfdG9fd3JhcCA9PSBjYWxjX2J5dGVzX3RvX3dyYXAoYnVmKSk7Ci0KICAgICBpZiAoIHJl Y19zaXplID4gYnl0ZXNfdG9fd3JhcCApCiAgICAgICAgIGluc2VydF93cmFwX3JlY29yZChi dWYsIHJlY19zaXplKTsKIAo= --------------020407000901070000090501 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel --------------020407000901070000090501--