Re: [PATCH 16/17] sym53c8xx: Remove pci_dev pointer from sym_shcb

[Jeff Garzik <jeff@garzik.org>]

Matthew Wilcox wrote:
> This structure is accessed by the device; the fewer Linux things in it,
> the better.  Using the pci_dev pointer from the hostdata requires a lot
> of changes:
> 
>  - Pass Scsi_Host to a lot of routines which currently take a sym_hcb.
>  - Set the Scsi_Host as the pci drvdata (instead of the sym_hcb)
> 
> Signed-off-by: Matthew Wilcox <willy@linux.intel.com>

Obviously this is a judgement call on your part... but did you at least 
consider passing sym_hcb for all cases instead?

This is a common driver decisions, and many authors choose to store a 
pointer to the kernel struct (Scsi_Host in this case) in their adapter 
private structure, since it is often _far_ more common to pass the 
driver-private struct in arguments.

It doesn't make much sense to do the additional indirection IFF the 
majority of the routine actually want the driver-private structure.

I ACK the patch either way...