From mboxrd@z Thu Jan 1 00:00:00 1970 From: Balbir Singh Subject: Re: [RFC] [PATCH] memory controller statistics Date: Sun, 07 Oct 2007 11:26:59 +0530 Message-ID: <4708752B.9080107@linux.vnet.ibm.com> References: <20070907033942.4A6541BFA52@siro.lan> <20071004051332.9BE2C1BF95B@siro.lan> <4705B4AA.4070604@linux.vnet.ibm.com> Reply-To: balbir-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <4705B4AA.4070604-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: balbir-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org Cc: containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org, minoura-jCdQPDEk3idL9jVzuh4AOg@public.gmane.org, YAMAMOTO Takashi List-Id: containers.vger.kernel.org Balbir Singh wrote: > YAMAMOTO Takashi wrote: >>> hi, >>> >>> i implemented some statistics for your memory controller. >>> >>> it's tested with 2.6.23-rc2-mm2 + memory controller v7. >>> i think it can be applied to 2.6.23-rc4-mm1 as well. >>> >>> YAMOMOTO Takshi >>> >>> todo: something like nr_active/inactive in /proc/vmstat. >> here's the version i'm working on currently. any comments? >> >> changes from the previous version: >> >> - adapt to 2.6.23-rc8-mm2, container -> cgroup rename. >> - reflect some of comments on this list. >> - rename some macros as suggested by balbir >> - sprinkle some inlines as suggested by balbir. >> - remove "isolate" statistics >> - remove PAGE_CONTAINER_CACHE hack and >> add "flags" member to page_container instead. >> - make counters atomic_long_t. >> - add some comments. >> - coding style. >> - implement nr_active/nr_inactive. they show numbers of pages on >> per-cgroup lru lists. >> >> todo: >> - consider to make counters per-cpu. >> - more statistics. >> >> YAMAMOTO Takashi > > Hi, YAMAMOTO-San > > Looks much better, I did a quick review, it looks nice to me. > I'll test the patches and get back. > > Thank you for working on this, > Forgot to mention one other detail, could we track the statistics in bytes? We track usage and limit in bytes currently. I am open to opinions on this, but the last time we discussed numbers, tracking bytes was the preferred approach. -- Warm Regards, Balbir Singh Linux Technology Center IBM, ISTL