From: Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
To: Rusty Russell <rusty-8n+1lVoiYb80n/F98K4Iww@public.gmane.org>
Cc: kvm-devel <kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
Subject: Re: [PATCH 1/3] kvm_free_lapic() to pair with kvm_create_lapic()
Date: Mon, 08 Oct 2007 10:08:13 +0200 [thread overview]
Message-ID: <4709E56D.9060202@qumranet.com> (raw)
In-Reply-To: <200710081048.30985.rusty-8n+1lVoiYb80n/F98K4Iww@public.gmane.org>
Rusty Russell wrote:
> Instead of the asymetry of kvm_free_apic, implement kvm_free_lapic().
> And guess what? I found a minor bug: we don't need to hrtimer_cancel()
> from kvm_main.c, because we do that in kvm_free_apic().
>
> Also:
> 1) kvm_vcpu_uninit should be the reverse order from kvm_vcpu_init.
> 2) Don't set apic->regs_page to zero before freeing apic.
>
>
Applied all three, thanks.
--
Any sufficiently difficult bug is indistinguishable from a feature.
-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
prev parent reply other threads:[~2007-10-08 8:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-08 0:48 [PATCH 1/3] kvm_free_lapic() to pair with kvm_create_lapic() Rusty Russell
[not found] ` <200710081048.30985.rusty-8n+1lVoiYb80n/F98K4Iww@public.gmane.org>
2007-10-08 0:50 ` [PATCH 2/3] Hoist kvm_create_lapic() into kvm_vcpu_init() Rusty Russell
[not found] ` <200710081050.48794.rusty-8n+1lVoiYb80n/F98K4Iww@public.gmane.org>
2007-10-08 0:55 ` [PATCH 3/3] Remove gratuitous casts from lapic.c Rusty Russell
2007-10-08 8:08 ` Avi Kivity [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4709E56D.9060202@qumranet.com \
--to=avi-atkuwr5tajbwk0htik3j/w@public.gmane.org \
--cc=kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
--cc=rusty-8n+1lVoiYb80n/F98K4Iww@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.