All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: KOVACS Krisztian <hidden@sch.bme.hu>
Cc: netfilter-devel@vger.kernel.org,
	Balazs Scheidler <bazsi@balabit.hu>,
	Toth Laszlo Attila <panther@balabit.hu>
Subject: Re: [PATCH 10/13] iptables socket match
Date: Mon, 08 Oct 2007 10:32:57 +0200	[thread overview]
Message-ID: <4709EB39.4010504@trash.net> (raw)
In-Reply-To: <20071002204451.11052.79411.stgit@nessa.odu>

KOVACS Krisztian wrote:
> +config NETFILTER_XT_MATCH_SOCKET
> +	tristate '"socket" match support'
> +	depends on NETFILTER_TPROXY
> +	depends on NETFILTER_XTABLES

EXPERIMENTAL please.

> +static bool
> +socket_match(const struct sk_buff *skb,
> +	     const struct net_device *in,
> +	     const struct net_device *out,
> +	     const struct xt_match *match,
> +	     const void *matchinfo,
> +	     int offset,
> +	     unsigned int protoff,
> +	     bool *hotdrop)
> +{
> +	const struct iphdr *iph = ip_hdr(skb);
> +	struct udphdr _hdr, *hp;
> +	struct sock *sk;
> +
> +	/* TCP/UDP only */
> +	if (iph->protocol != IPPROTO_TCP && iph->protocol != IPPROTO_UDP)
> +		return false;


How about making sure that its only used in a -p udp or -p tcp
rule in ->checkentry() instead?

  reply	other threads:[~2007-10-08  8:35 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-02 20:39 [PATCH 00/13] Transparent Proxying Patches, Take 4 KOVACS Krisztian
2007-10-02 20:40 ` [PATCH 01/13] Loosen source address check on IPv4 output KOVACS Krisztian
2007-10-02 20:40 ` [PATCH 02/13] Implement IP_TRANSPARENT socket option KOVACS Krisztian
2007-10-02 20:41 ` [PATCH 03/13] Allow binding to non-local addresses if IP_TRANSPARENT is set KOVACS Krisztian
2007-10-02 20:41 ` [PATCH 04/13] Conditionally enable transparent flow flag when connecting KOVACS Krisztian
2007-10-02 20:42 ` [PATCH 05/13] Handle TCP SYN+ACK/ACK/RST transparency KOVACS Krisztian
2007-10-02 20:42 ` [PATCH 06/13] Port redirection support for TCP KOVACS Krisztian
2007-10-02 20:43 ` [PATCH 07/13] Export UDP socket lookup function KOVACS Krisztian
2007-10-02 20:43 ` [PATCH 08/13] Split Netfilter IPv4 defragmentation into a separate module KOVACS Krisztian
2007-10-08  8:30   ` Patrick McHardy
2007-10-17 19:11   ` Krzysztof Oledzki
2007-10-23 18:26     ` KOVACS Krisztian
2007-10-02 20:44 ` [PATCH 09/13] iptables tproxy core KOVACS Krisztian
2007-10-02 20:44 ` [PATCH 10/13] iptables socket match KOVACS Krisztian
2007-10-08  8:32   ` Patrick McHardy [this message]
2007-10-02 20:45 ` [PATCH 11/13] iptables TPROXY target KOVACS Krisztian
2007-10-08  8:34   ` Patrick McHardy
2007-10-02 20:45 ` [PATCH 12/13] Don't lookup the socket if there's a socket attached to the skb KOVACS Krisztian
2007-10-02 20:46 ` [PATCH 13/13] " KOVACS Krisztian
  -- strict thread matches above, loose matches on Subject: below --
2007-09-30 20:51 [PATCH 00/13] Transparent Proxying Patches, Take 3 KOVACS Krisztian
2007-09-30 20:53 ` [PATCH 10/13] iptables socket match KOVACS Krisztian
2007-09-30 21:43   ` Jan Engelhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4709EB39.4010504@trash.net \
    --to=kaber@trash.net \
    --cc=bazsi@balabit.hu \
    --cc=hidden@sch.bme.hu \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=panther@balabit.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.