From: Johannes Sixt <j.sixt@viscovery.net>
To: Gerrit Pape <pape@smarden.org>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH] git-config: handle --file option with relative pathname properly
Date: Tue, 09 Oct 2007 15:20:36 +0200 [thread overview]
Message-ID: <470B8024.2050106@viscovery.net> (raw)
In-Reply-To: <20071009124932.1184.qmail@395d4a80f3eafd.315fe32.mid.smarden.org>
Gerrit Pape schrieb:
> @@ -189,7 +189,11 @@ int cmd_config(int argc, const char **argv, const char *prefix)
> else if (!strcmp(argv[1], "--file") || !strcmp(argv[1], "-f")) {
> if (argc < 3)
> usage(git_config_set_usage);
> - setenv(CONFIG_ENVIRONMENT, argv[2], 1);
> + if (argv[2][0] == '/')
Please use is_absolute_path() here.
> + name = argv[2];
> + else
> + name = name ? prefix_filename(name, strlen(name), argv[2]) : argv[2];
Can't you avoid this ternary here? There's already an 'if' with the same
'else' branch.
> + setenv(CONFIG_ENVIRONMENT, name, 1);
> argc--;
> argv++;
> }
-- Hannes
next prev parent reply other threads:[~2007-10-09 13:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-09 12:49 [PATCH] git-config: handle --file option with relative pathname properly Gerrit Pape
2007-10-09 13:14 ` Johannes Schindelin
2007-10-09 13:20 ` Johannes Sixt [this message]
2007-10-12 11:32 ` [PATCH amend] " Gerrit Pape
2007-10-12 12:08 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=470B8024.2050106@viscovery.net \
--to=j.sixt@viscovery.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=pape@smarden.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.