From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from de01egw02.freescale.net (de01egw02.freescale.net [192.88.165.103]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "de01egw02.freescale.net", Issuer "Thawte Premium Server CA" (verified OK)) by ozlabs.org (Postfix) with ESMTP id CC392DDEBF for ; Wed, 10 Oct 2007 05:18:24 +1000 (EST) Message-ID: <470BD3F8.6000006@freescale.com> Date: Tue, 09 Oct 2007 14:18:16 -0500 From: Timur Tabi MIME-Version: 1.0 To: Kumar Gala Subject: Re: [PATCH] qe: add function qe_clock_source References: <1191945199488-git-send-email-timur@freescale.com> <470BA5DF.5060206@freescale.com> <2E830F97-ADAE-43CA-9BD3-BEBFEFBE1D5C@kernel.crashing.org> <470BAAA2.30400@freescale.com> <8D4AA8EB-812F-4E58-A13C-CE3BA72037F3@kernel.crashing.org> <470BAFA8.1060408@freescale.com> <470BB09D.7060304@freescale.com> <470BB0E6.4050801@freescale.com> <470BC484.3060702@freescale.com> <91CB543F-A0F2-42A4-AA5C-6F8FC99F9EC3@kernel.crashing.org> <470BC5CA.1010105@freescale.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Cc: linuxppc-dev@ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Kumar Gala wrote: > Ok. I guess I'm not in favor of changing the device tree to address > this issue. I think it would be solved if "dtc" had #define support. Not really. The #defines would then need to match the enum, and that's dual maintenance. This method is better because you can use the real name of the clock source in the DTS. That keeps the DTS from having to know the internal representation of clock sources. (BTW, when I said "I just understand", I meant "I just don't understand".) -- Timur Tabi Linux Kernel Developer @ Freescale