From: "Jun'ichi Nomura" <j-nomura@ce.jp.nec.com>
To: device-mapper development <dm-devel@redhat.com>
Subject: [PATCH] dmeventd: fix typo in configure.in causing monitoring failure
Date: Tue, 09 Oct 2007 18:46:06 -0400 [thread overview]
Message-ID: <470C04AE.3060701@ce.jp.nec.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 800 bytes --]
Hi,
Attached patch fixes a typo in configure.in of device-mapper.
As a result of the typo, DMEVENTD_PATH in libdevmapper-event
could be set ignoring "exec_prefix" and the monitoring may not
work.
For example, LVM2 may complain it can't communicate with dmeventd:
# lvm.static lvcreate -m1 -l1 testvg
Unable to read from event server.
Unable to read from event server.
testvg-lvol0: event registration failed: Input/output error
testvg/lvol0: mirror segment monitoring function failed.
Logical volume "lvol0" created
while in the background, dmeventd caused segfault soon after startup:
From syslog:
dmeventd[688]: dmeventd ready for processing.
kernel: dmeventd[688]: segfault at 08000000 eip 4ff615a7 esp bfafe2f8 error 4
Thanks,
--
Jun'ichi Nomura, NEC Corporation of America
[-- Attachment #2: dm-fix-configure-dmeventd-prefix.patch --]
[-- Type: text/x-patch, Size: 1268 bytes --]
Fix a typo in configure.in ("dmeventd_pref" should be "dmeventd_prefix")
As a result of this typo, LVM2 commands might try to invoke dmeventd
which doesn't match to the library version and monitoring fails to work.
Index: device-mapper.work/configure.in
===================================================================
--- device-mapper.work.orig/configure.in
+++ device-mapper.work/configure.in
@@ -394,7 +394,7 @@ if test "$DMEVENTD" = yes; then
AC_ARG_WITH(dmeventd-path,
[ --with-dmeventd-path=PATH dmeventd path [[${exec_prefix}/sbin/dmeventd]] ],
[ AC_DEFINE_UNQUOTED(DMEVENTD_PATH,"$withval") ],
- [ AC_DEFINE_UNQUOTED(DMEVENTD_PATH,"$dmeventd_pref/sbin/dmeventd") ])
+ [ AC_DEFINE_UNQUOTED(DMEVENTD_PATH,"$dmeventd_prefix/sbin/dmeventd") ])
fi
################################################################################
AC_SUBST(usrlibdir)
Index: device-mapper.work/configure
===================================================================
--- device-mapper.work.orig/configure
+++ device-mapper.work/configure
@@ -6646,7 +6646,7 @@ _ACEOF
else
cat >>confdefs.h <<_ACEOF
-#define DMEVENTD_PATH "$dmeventd_pref/sbin/dmeventd"
+#define DMEVENTD_PATH "$dmeventd_prefix/sbin/dmeventd"
_ACEOF
fi
[-- Attachment #3: Type: text/plain, Size: 0 bytes --]
reply other threads:[~2007-10-09 22:46 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=470C04AE.3060701@ce.jp.nec.com \
--to=j-nomura@ce.jp.nec.com \
--cc=dm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.