All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Abd-El-Malek <mabdelmalek@cmu.edu>
To: xen-devel@lists.xensource.com
Subject: [PATCH] linux-2.6.18-xen.hg: check that awk supports 'gensub' command
Date: Tue, 09 Oct 2007 22:53:37 -0400	[thread overview]
Message-ID: <470C3EB1.6020207@cmu.edu> (raw)

[-- Attachment #1: Type: text/plain, Size: 409 bytes --]

The linux-2.6.18-xen.hg/scripts/Makefile.xen.awk script depends on the 
GNU AWK-specific function "gensub".  If another awk is used (e.g., 
Debian installs mawk by default), the lack of gensub trickles down to 
cause the -xen.c files to not be compiled.  This was time-consuming to 
track.  So we should check that the awk program supports 'gensub'.

Signed-off-by: Michael Abd-El-Malek <mabdelmalek@cmu.edu>

[-- Attachment #2: patch --]
[-- Type: text/plain, Size: 686 bytes --]

diff -r b0ec211da98a scripts/Makefile.build
--- a/scripts/Makefile.build	Fri Oct 05 10:51:53 2007 +0100
+++ b/scripts/Makefile.build	Tue Oct 09 22:45:45 2007 -0400
@@ -71,6 +71,8 @@ ifeq ($(CONFIG_XEN),y)
 ifeq ($(CONFIG_XEN),y)
 $(objtree)/scripts/Makefile.xen: $(srctree)/scripts/Makefile.xen.awk $(srctree)/scripts/Makefile.build
 	@echo '  Updating $@'
+	$(if $(shell echo a | $(AWK) '{ print gensub(/a/, "AA", "g"); }'),\
+        ,$(error 'Your awk program does not define gensub.  Use gawk or another awk with gensub'))
 	@$(AWK) -f $< $(filter-out $<,$^) >$@
 
 xen-src-single-used-m	:= $(patsubst $(srctree)/%,%,$(wildcard $(addprefix $(srctree)/,$(single-used-m:.o=-xen.c))))

[-- Attachment #3: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

             reply	other threads:[~2007-10-10  2:53 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-10  2:53 Michael Abd-El-Malek [this message]
2007-10-10  7:54 ` [PATCH] linux-2.6.18-xen.hg: check that awk supports 'gensub' command Jan Beulich
2007-10-10  8:47   ` Keir Fraser
2007-10-10 14:50     ` Michael Abd-El-Malek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=470C3EB1.6020207@cmu.edu \
    --to=mabdelmalek@cmu.edu \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.