All of lore.kernel.org
 help / color / mirror / Atom feed
From: Satoshi OSHIMA <satoshi.oshima.fk@hitachi.com>
To: Evgeniy Polyakov <johnpol@2ka.mipt.ru>
Cc: Andi Kleen <andi@firstfloor.org>,
	David Miller <davem@davemloft.net>,
	Herbert Xu <herbert@gondor.apana.org.au>,
	netdev <netdev@vger.kernel.org>, ?? ?? <yoshfuji@linux-ipv6.org>,
	Yumiko SUGITA <yumiko.sugita.yf@hitachi.com>,
	"??@RedHat" <haoki@redhat.com>
Subject: Re: [RFC/PATCH 2/4] UDP memory usage accounting (take 4): accounting unit and variable
Date: Wed, 10 Oct 2007 17:14:12 +0900	[thread overview]
Message-ID: <470C89D4.8080409@hitachi.com> (raw)
In-Reply-To: <20071007100938.GA24475@2ka.mipt.ru>

Hi Evgeniy,

Thank you for your comment.

> Hi.
> 
> On Sat, Oct 06, 2007 at 12:01:07AM +0900, Satoshi OSHIMA (satoshi.oshima.fk@hitachi.com) wrote:
>> --- 2.6.23-rc3-udp_limit.orig/net/ipv4/udp.c
>> +++ 2.6.23-rc3-udp_limit/net/ipv4/udp.c
>> @@ -113,6 +113,10 @@ DEFINE_SNMP_STAT(struct udp_mib, udp_sta
>>  struct hlist_head udp_hash[UDP_HTABLE_SIZE];
>>  DEFINE_RWLOCK(udp_hash_lock);
>>  
>> +atomic_t udp_memory_allocated;
>> +
>> +EXPORT_SYMBOL(udp_memory_allocated);
>> +
> 
> Why do you export this variable?
> It is not accessed from modules in your patchset.

Good point! I'll fix it.

Satoshi Oshima

  reply	other threads:[~2007-10-10  8:14 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-05 14:59 [RFC/PATCH 0/4]UDP memory accounting (take 4) Satoshi OSHIMA
2007-10-05 15:00 ` [RFC/PATCH 1/4] UDP memory usage accounting (take 4): fix send buffer check Satoshi OSHIMA
2007-10-05 15:01 ` [RFC/PATCH 2/4] UDP memory usage accounting (take 4): accounting unit and variable Satoshi OSHIMA
2007-10-07 10:09   ` Evgeniy Polyakov
2007-10-10  8:14     ` Satoshi OSHIMA [this message]
2007-10-05 15:02 ` [RFC/PATCH 3/4] UDP memory usage accounting (take 4): memory usage accounting Satoshi OSHIMA
2007-10-05 15:02 ` [RFC/PATCH 4/4] UDP memory usage accounting (take 4): memory limitation Satoshi OSHIMA
2007-10-05 15:52   ` Stephen Hemminger
2007-10-11 12:51     ` Satoshi OSHIMA
2007-10-11 19:46       ` Stephen Hemminger
2007-10-12 11:58         ` Satoshi OSHIMA

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=470C89D4.8080409@hitachi.com \
    --to=satoshi.oshima.fk@hitachi.com \
    --cc=andi@firstfloor.org \
    --cc=davem@davemloft.net \
    --cc=haoki@redhat.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=johnpol@2ka.mipt.ru \
    --cc=netdev@vger.kernel.org \
    --cc=yoshfuji@linux-ipv6.org \
    --cc=yumiko.sugita.yf@hitachi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.