From: Lachlan McIlroy <lachlan@sgi.com>
To: xfs-dev <xfs-dev@sgi.com>, xfs-oss <xfs@oss.sgi.com>
Subject: review: use correct buffer flags when reading superblock
Date: Wed, 10 Oct 2007 18:37:47 +1000 [thread overview]
Message-ID: <470C8F5B.90705@sgi.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 333 bytes --]
When reading the superblock during log recovery we are not setting
the correct buffer flags. Specifically we are not turning off flags
we do not need such as XBF_ASYNC that is causing the synchronous
xfs_iowait() to hang. We should also turn off XBF_WRITE and remove
the buffer from the delay write queue just to be safe.
Lachlan
[-- Attachment #2: xfs_getsb.diff --]
[-- Type: text/x-patch, Size: 433 bytes --]
--- fs/xfs/xfs_log_recover.c_1.329 2007-10-10 15:59:18.000000000 +1000
+++ fs/xfs/xfs_log_recover.c 2007-10-10 16:03:08.000000000 +1000
@@ -3824,7 +3824,10 @@ xlog_do_recover(
*/
bp = xfs_getsb(log->l_mp, 0);
XFS_BUF_UNDONE(bp);
+ XFS_BUF_UNWRITE(bp);
+ XFS_BUF_UNDELAYWRITE(bp);
XFS_BUF_READ(bp);
+ XFS_BUF_UNASYNC(bp);
xfsbdstrat(log->l_mp, bp);
if ((error = xfs_iowait(bp))) {
xfs_ioerror_alert("xlog_do_recover",
next reply other threads:[~2007-10-10 8:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-10 8:37 Lachlan McIlroy [this message]
2007-10-10 9:34 ` review: use correct buffer flags when reading superblock Christoph Hellwig
2007-10-10 11:25 ` David Chinner
2007-10-18 15:46 ` Christoph Hellwig
2007-10-19 1:32 ` Lachlan McIlroy
2007-10-19 2:14 ` David Chinner
2007-10-10 11:28 ` David Chinner
2007-10-11 2:42 ` Lachlan McIlroy
2007-10-11 3:30 ` David Chinner
2007-10-11 7:23 ` Lachlan McIlroy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=470C8F5B.90705@sgi.com \
--to=lachlan@sgi.com \
--cc=xfs-dev@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.