From mboxrd@z Thu Jan 1 00:00:00 1970 From: Josh Triplett Subject: Re: idio{,ma}tic typos (was Re: + fix-vm_can_nonlinear-check-in-sys_remap_file_pages.patch added to -mm tree) Date: Wed, 10 Oct 2007 04:45:46 -0700 Message-ID: <470CBB6A.7020305@freedesktop.org> References: <20071010104540.GA6366@localhost.sw.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from mail4.sea5.speakeasy.net ([69.17.117.6]:55846 "EHLO mail4.sea5.speakeasy.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752103AbXJJLpx (ORCPT ); Wed, 10 Oct 2007 07:45:53 -0400 In-Reply-To: <20071010104540.GA6366@localhost.sw.ru> Sender: linux-sparse-owner@vger.kernel.org List-Id: linux-sparse@vger.kernel.org To: Alexey Dobriyan Cc: Al Viro , linux-kernel@vger.kernel.org, davej@codemonkey.org.uk, Pierre Ossman , akpm@osdl.org, linux-sparse@vger.kernel.org Alexey Dobriyan wrote: > ["if (!x & y)" patch from yanzheng@] > ["if (!x & y)" patch from adobriyan@] > ["if (!x & y)" patches from viro@] > > While we're at it, below is somewhat ugly sparse patch for detecting > "&& 0x" typos. Excellent idea! I think it applies to || as well. I'll most likely add a -Wboolean-logic-on-bit-constant to turn this warning on. Any reason why this wouldn't apply to octal constants or to GCC's new binary constants? I can trivially modify this patch to handle those as well, just by dropping the check for an 'x' or 'X', and renaming the flag. As far as patch beauty goes, I think this patch looks just fine. - Josh Triplett