All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vlad Lungu <vlad@comsys.ro>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] MIPS question
Date: Thu, 11 Oct 2007 12:19:08 +0300	[thread overview]
Message-ID: <470DEA8C.8020704@comsys.ro> (raw)
In-Reply-To: <470D937C.6050600@ruby.dti.ne.jp>

Shinya Kuribayashi wrote:
> Vlad Lungu wrote:
>   
>> in include/asm-mips/addrspace.h line 52, there is a
>>
>> #define UNCACHED_SDRAM(a) PHYSADDR(a)
>>
>> The question is: shouldn't we use KSEG1ADDR() instead of PHYSADDR()?
>>     
>
> I think we should. At least my target boards need that change.
>
> http://www.nabble.com/MIPS-cache-management-%28and-build%29-questions.-tf4434068.html#a12651921
>   
And what board would that be? Or it's not in the tree?
> note: Wrt dcache_disable() part, please take into account
>       Stefan's comment.
>
> Anyway I seriously wonder whether other mips ports work as it is.
>
>   
<comment mode="AOL"> me too </comment>

The RAM might be mapped at 0 too on some boards, that's why it works with PHYSADDR(). Or people are
simply bootelf-ing Linux, that's why the bug was not catched before (I think the only use of that 
macro is in lib_mips/mips_linux.c i.e. bootm). Note that the Au1x00 boards ( and another one, can't 
remember the name) do 0x20000000|a or something like that, which when you go from KSEG0 (0x8???????)
produces 0xa???????, an address in KSEG1.

Wolfgang, should I submit a patch on this for 1.3.0?

Vlad

  reply	other threads:[~2007-10-11  9:19 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-10 20:11 [U-Boot-Users] MIPS question Vlad Lungu
2007-10-11  3:07 ` Shinya Kuribayashi
2007-10-11  9:19   ` Vlad Lungu [this message]
2007-10-11 15:30     ` Shinya Kuribayashi
  -- strict thread matches above, loose matches on Subject: below --
2007-10-11 14:36 Tim Braun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=470DEA8C.8020704@comsys.ro \
    --to=vlad@comsys.ro \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.