All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
To: linux-ext4 <linux-ext4@vger.kernel.org>,
	Theodore Tso <tytso@mit.edu>,
	Andreas Dilger <adilger@clusterfs.com>,
	Mingming Cao <cmm@us.ibm.com>
Subject: When to set EXT4_FEATURE_RO_COMPAT_LARGE_FILE  ?
Date: Thu, 11 Oct 2007 22:34:13 +0530	[thread overview]
Message-ID: <470E578D.4040308@linux.vnet.ibm.com> (raw)

Right now we do this  in ext4_do_update_inode

 if (ei->i_disksize > 0x7fffffffULL) {

.....
.....

EXT4_SET_RO_COMPAT_FEATURE(sb, EXT4_FEATURE_RO_COMPAT_LARGE_FILE);

That is if i_disksize is greater that 2**31 -1  we set the flag

But in ext4_inode the size of i_size is 32 bits

__le32  i_size;         /* Size in bytes */

That means it should be able to store ffffffffULL.

Why did we decided to enable the EXT4_FEATURE_RO_COMPAT_LARGE_FILE when we cross 2**31 -1 ?

NOTE: With EXT4_FEATURE_RO_COMPAT_LARGE_FILE we store the higer order 32 bits of i_size in i_dir_acl.


-aneesh

                 reply	other threads:[~2007-10-11 17:04 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=470E578D.4040308@linux.vnet.ibm.com \
    --to=aneesh.kumar@linux.vnet.ibm.com \
    --cc=adilger@clusterfs.com \
    --cc=cmm@us.ibm.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.