From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
To: Andreas Dilger <adilger@clusterfs.com>
Cc: akpm@linux-foundation.org, linux-ext4@vger.kernel.org
Subject: Re: [PATCH] ext2: Fix the max file size for ext2 file system.
Date: Fri, 12 Oct 2007 09:46:47 +0530 [thread overview]
Message-ID: <470EF52F.6060004@linux.vnet.ibm.com> (raw)
In-Reply-To: <20071011195449.GT8122@schatzie.adilger.int>
Andreas Dilger wrote:
> On Oct 11, 2007 20:20 +0530, Aneesh Kumar K.V wrote:
>> + /* indirect blocks */
>> + meta_blocks = 1;
>> + /* double indirect blocks */
>> + meta_blocks += 1 + (1LL << (bits-2));
>> + /* tripple indirect blocks */
>> + meta_blocks += 1 + (1LL << (bits-2)) + (1LL << (2*(bits-2)));
>
> It may be worthwhile calculating how many indirect blocks there actually
> are in a file that size.
The math become more confusing for that right ?. I am not sure we need to be that specific.
>Also note that your comments are backward -
> there is at most a single triple indirect block per file.
What i meant by those comment was, the count of meta data blocks taken for
different type of indirect blocks.
-aneesh
next prev parent reply other threads:[~2007-10-12 4:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-11 14:50 [PATCH] ext2: Fix the max file size for ext2 file system Aneesh Kumar K.V
2007-10-11 14:50 ` [PATCH] ext3: Fix the max file size for ext3 " Aneesh Kumar K.V
2007-10-11 19:54 ` [PATCH] ext2: Fix the max file size for ext2 " Andreas Dilger
2007-10-12 4:16 ` Aneesh Kumar K.V [this message]
-- strict thread matches above, loose matches on Subject: below --
2007-10-22 14:55 Aneesh Kumar K.V
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=470EF52F.6060004@linux.vnet.ibm.com \
--to=aneesh.kumar@linux.vnet.ibm.com \
--cc=adilger@clusterfs.com \
--cc=akpm@linux-foundation.org \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.