From: Paul Eggleton <paul.eggleton@linux.intel.com>
To: Enrico Scholz <enrico.scholz@sigma-chemnitz.de>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 2/2] base: make feature backfilling happen earlier
Date: Mon, 28 Jan 2013 14:19:57 +0000 [thread overview]
Message-ID: <4710226.v3bfS80rgU@helios> (raw)
In-Reply-To: <lypq0pl8ee.fsf@ensc-virt.intern.sigma-chemnitz.de>
On Monday 28 January 2013 14:55:05 Enrico Scholz wrote:
> Richard Purdie <richard.purdie@linuxfoundation.org> writes:
> >> > Backfilling DISTRO_FEATURES and MACHINE_FEATURES with _append
> >> > statements
> >> > happens too late to use those variables with conditional inherits, like
> >>
> >> > this:
> >> This causes regressions for setups where DISTRO_FEATURES_BACKFILL uses
> >> the override mechanism. E.g. I have
> >>
> >> | DISTRO_FEATURES_BACKFILL_mydist = "ld-is-gold ${${PROJECT_FEATURES}"
> >> | DISTRO_FEATURES_INITMAN_mydist = "systemd"
> >>
> >> Before this commit, DISTRO_FEATURES contained 'ld-is-gold' and the
> >> project features. Now, project features + ld-is-gold vanished and
> >> pulseaudio is in again.
> >
> > I don't think its possible to make everything work :(
> >
> > The question is therefore how do we want to proceed? I'll take further
> > proposed patches but I don't know what the best thing to do here is...
>
> I made my setup (--> overriding DISTRO_FEATURES_BACKFILL by distro
> configuration) working again by assigning it weakly in bitbake.conf:
>
> -DISTRO_FEATURES_BACKFILL = "pulseaudio ${DISTRO_FEATURES_INITMAN}"
> +DISTRO_FEATURES_BACKFILL ?= "pulseaudio ${DISTRO_FEATURES_INITMAN}"
>
> ditto for MACHINE_FEATURES_BACKFILL.
Why are you assigning *_FEATURES_BACKFILL at all?
Cheers,
Paul
--
Paul Eggleton
Intel Open Source Technology Centre
next prev parent reply other threads:[~2013-01-28 14:35 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-24 17:52 [PATCH 0/2] DISTRO_FEATURES compatibility fixes Ross Burton
2013-01-24 17:52 ` [PATCH 1/2] bitbake.conf: unbreak all builds with custom DISTRO_FEATURES Ross Burton
2013-01-24 17:52 ` [PATCH 2/2] base: make feature backfilling happen earlier Ross Burton
2013-01-25 18:06 ` Enrico Scholz
2013-01-28 12:54 ` Richard Purdie
2013-01-28 13:55 ` Enrico Scholz
2013-01-28 14:19 ` Paul Eggleton [this message]
2013-01-28 14:52 ` Enrico Scholz
2013-01-28 15:00 ` Phil Blundell
2013-01-28 15:44 ` Enrico Scholz
2013-01-28 15:58 ` Paul Eggleton
2013-01-28 16:23 ` Enrico Scholz
2013-01-28 16:34 ` Paul Eggleton
2013-01-29 11:07 ` Enrico Scholz
2013-01-28 16:15 ` Phil Blundell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4710226.v3bfS80rgU@helios \
--to=paul.eggleton@linux.intel.com \
--cc=enrico.scholz@sigma-chemnitz.de \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.