From: Shinya Kuribayashi <skuribay@ruby.dti.ne.jp>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [patch] rtl8139.c: use PCI IO map
Date: Sun, 14 Oct 2007 00:46:26 +0900 [thread overview]
Message-ID: <4710E852.7080003@ruby.dti.ne.jp> (raw)
In-Reply-To: <200710132316265009039@gmail.com>
Lucas Jin wrote:
> Wolfgang Denk Wrote:
>
>> In message <200710131722183904740@gmail.com> you wrote:
>>> Signed-off-by: Lucas Jin <lucasjin@gmail.com>
>>>
>>> --- ./drivers/rtl8139.c.orig 2007-10-12 22:17:52.000000000 +0800
>>> +++ ./drivers/rtl8139.c 2007-10-13 17:34:40.117515408 +0800
>> Could you please explain which problem this patch is supposed to fix?
>
> The rtl8139 specification says the configuration registers can be accessed through PCI memory mapping or PCI IO mapping.
>
> The u-boot driver uses PCI memory mapping, but it doesn't work, so I changed it to PCI IO mapping.
On my target RTL8139 or its variant works fine without such a change.
Why do you think doesn't work? Could you elaborate please?
> The driver of rtl8139 in Linux Kernel also uses PCI IO mapping to access the configuration registers.
Do you mean CONFIG_8139TOO_PIO?
thanks,
Shinya
next prev parent reply other threads:[~2007-10-13 15:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-13 13:53 [U-Boot-Users] [patch] rtl8139.c: use PCI IO map Lucas Jin
2007-10-13 14:43 ` Wolfgang Denk
2007-10-13 15:16 ` Lucas Jin
2007-10-13 15:46 ` Shinya Kuribayashi [this message]
2007-10-14 1:12 ` Lucas Jin
2007-10-15 15:56 ` Masami Komiya
2007-10-16 1:17 ` Lucas Jin
2007-10-15 19:02 ` Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4710E852.7080003@ruby.dti.ne.jp \
--to=skuribay@ruby.dti.ne.jp \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.