From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f48.google.com (mail-ej1-f48.google.com [209.85.218.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 580637C for ; Tue, 24 May 2022 19:08:56 +0000 (UTC) Received: by mail-ej1-f48.google.com with SMTP id rs12so25525112ejb.13 for ; Tue, 24 May 2022 12:08:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=2OulZq3Irlc58uEaDk3npzMcuhHJigRPmtDLvl24/rI=; b=WyOcrh4LJIMo3HCPOQWirbN/TJkvHif36lLojpxyJDhYud5TualgotcCkgcTvRO/pq fX1q0MxY4T7EUloEsrlNE/ubBG25fPlKLtE+zICmsYR9xVa8f0DZQ/3XC/00d/ZrfBj5 7mjAAMXBwdKl4PzJmzUoqmFmmnuKiU6taXgjxER0By1YWVzrnw9+cfXMG3kuX9fW9+nZ H/pGzVoOP6cLrBSqzgjj71UYdJ5pstv9aa7alosWyvC1UzTvPQLrZD3+9UR+e6ggOa9h OeHRY9LY3AgoQUPrh4lnsrQwSO4hGnqeyP2gbTb7soQ6ieftA61Nf93Eig9+zZEDAu+H nTsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=2OulZq3Irlc58uEaDk3npzMcuhHJigRPmtDLvl24/rI=; b=D2DknqBoXHF1OXlq8Qdn4asV/0/Ki1Mtr2i6C3NvXd03Z1UM55ZTGCDnEiid5wkxjK zsiXkVSm/GHBq2ib2Rq89SN9Q+8Vabj8UgYuN7mi2YFw6bNCwTxLes2jyFI/4vQ9WgzD 2Q6Y2UHkeMqBbF172CFkH6Y01fOcICx1sBx2bU7/yXObcuSX8QuPv0hmkDtnODIK5b/b kqgUUzkyn3S6M+YBExLoN6HhNGPyJpAJfPuw3heb7vUJCy/GyWe+4NUfAUPLouR4HW9v A+YvnSWgvMMFpCs5b2sfyVBPPVeB4162UpBuOm3b+in5dCRNAIG4P3Xnl4ZeC8MIm1Pb RfrA== X-Gm-Message-State: AOAM531Vf4yey9gFIyebwmntH4qbPCwSVtdaEO2Vlabc6GIaB4Tj96PP GnC5LULq7iA2DjxMx5Vv5Q/YCUTIkfzobg== X-Google-Smtp-Source: ABdhPJy6tiBlS7Y9PEG2y6NKd0gtJct5hHGBgdFkw2WWZBgKIw/lQUaM7aC1rncE2M7LApgGvxxnRQ== X-Received: by 2002:a17:906:4787:b0:6f4:2f25:f9ff with SMTP id cw7-20020a170906478700b006f42f25f9ffmr27258921ejc.116.1653419334498; Tue, 24 May 2022 12:08:54 -0700 (PDT) Received: from kista.localnet (213-161-3-76.dynamic.telemach.net. [213.161.3.76]) by smtp.gmail.com with ESMTPSA id w9-20020a1709064a0900b006fed85c1a8fsm2777972eju.202.2022.05.24.12.08.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 May 2022 12:08:54 -0700 (PDT) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: mripard , wens , "benlypan@gmail.com" Cc: airlied , daniel , samuel , dri-devel , linux-arm-kernel , linux-sunxi , linux-kernel Subject: Re: Re: [PATCH] drm/sun4i: mixer: fix scanline for V3s and D1 Date: Tue, 24 May 2022 21:08:53 +0200 Message-ID: <4711779.GXAFRqVoOG@kista> In-Reply-To: <202205221848264427024@gmail.com> References: <20220521133443.1114749-1-benlypan@gmail.com> <3173956.44csPzL39Z@jernej-laptop> <202205221848264427024@gmail.com> Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Dne nedelja, 22. maj 2022 ob 12:48:27 CEST je benlypan@gmail.com napisal(a): > Hi Jernej! > > > Which SDK? All SDKs that I have or found on internet don't mention YUV nor RGB > > scanline limit. That doesn't mean there is none, I'm just unable to verify > > your claim. Did you test this by yourself? Also, please make YUV scanline > > change separate patch with fixes tag. > > Here is the code about scanline config for V3s: > https://github.com/Tina-Linux/tina-v3s-linux-4.9/blob/master/drivers/video/ fbdev/sunxi/disp2/disp/de/lowlevel_sun8iw8/de_feat.c#L55 > https://github.com/Tina-Linux/tina-v3s-linux-4.9/blob/master/drivers/video/ fbdev/sunxi/disp2/disp/de/lowlevel_sun8iw8/de_rtmx.c#L1212 > > And here is for D1: > https://gitlab.com/weidongshan/tina-d1-h/-/blob/main/lichee/linux-5.4/ drivers/video/fbdev/sunxi/disp2/disp/de/lowlevel_v2x/de_feat.c#L182 > https://gitlab.com/weidongshan/tina-d1-h/-/blob/main/lichee/linux-5.4/ drivers/video/fbdev/sunxi/disp2/disp/de/lowlevel_v2x/de_rtmx.c#L1588 Thanks for the links! > > I was tested it on V3s. Without this patch, the plane will not display > correctly if src_w large than 1024, for both YUV and RGB. I don't have a > device with D1, so D1 is not tested. But according to the SDK code of D1, > the scanline value of mixer1 is 1024. > > I'm new to submitting patches, So may I ask a question? If there is no > problem with this patch, what I need to do is to send new patches as you > suggested? https://www.kernel.org/doc/html/latest/process/submitting-patches.html I already requested changes, so you need to send v2. But wait until discussion is finished. Best regards, Jernej > > Best regards, > Genfu Pan > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C1041C433EF for ; Tue, 24 May 2022 19:10:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=IDwvK2csNs+X1BDh0G7OIp9UF/WPk/VoJCBE4aridKc=; b=gZPVSmrLLp04ty q7uDPhOI8i89W+o2gQwmmgMDqoNZxqipU2GLQbCRcvY7LrvSzv8ytO1io70fF7zZLGHgIWNd0D5rv GMWk3CwAefK6vTl4y4QegZtefSNu5cBrk7lzISD5zX0kg/FNch6sSvOt0RNqU6eKymUZQMenb4220 kK65j8yer+60abUZtu7z2PKrNcIU4OHtotdEEVr6uZ9U2IBZYVh2DRnEaUqA9lbKwir3av+R+PHVF ImHRtW6K1R9l5rZoZsGSDwGdQHUc/EISdm8wTK3UJfVN2ngCQrd39Q6ylggQX8hmYTEPUL6hZtA54 ZNdBa3vkbtvviqfmJSHw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ntZtt-008z3d-OK; Tue, 24 May 2022 19:09:01 +0000 Received: from mail-ej1-x62c.google.com ([2a00:1450:4864:20::62c]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ntZtq-008z2b-Bv for linux-arm-kernel@lists.infradead.org; Tue, 24 May 2022 19:08:59 +0000 Received: by mail-ej1-x62c.google.com with SMTP id jx22so23825291ejb.12 for ; Tue, 24 May 2022 12:08:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=2OulZq3Irlc58uEaDk3npzMcuhHJigRPmtDLvl24/rI=; b=WyOcrh4LJIMo3HCPOQWirbN/TJkvHif36lLojpxyJDhYud5TualgotcCkgcTvRO/pq fX1q0MxY4T7EUloEsrlNE/ubBG25fPlKLtE+zICmsYR9xVa8f0DZQ/3XC/00d/ZrfBj5 7mjAAMXBwdKl4PzJmzUoqmFmmnuKiU6taXgjxER0By1YWVzrnw9+cfXMG3kuX9fW9+nZ H/pGzVoOP6cLrBSqzgjj71UYdJ5pstv9aa7alosWyvC1UzTvPQLrZD3+9UR+e6ggOa9h OeHRY9LY3AgoQUPrh4lnsrQwSO4hGnqeyP2gbTb7soQ6ieftA61Nf93Eig9+zZEDAu+H nTsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=2OulZq3Irlc58uEaDk3npzMcuhHJigRPmtDLvl24/rI=; b=gNzsZf/IEyE7gAtbYnCoc0CvWETbsLl/gvOtN4QvENci/psrEC+3PFO34fGEA3/xLT +S+3HnmNmHH+T0/Y/hyLusn9lyrXRWruvz8WdcS4a0KcowUxlmPjq5oHN5cXEcLTRX1V IcAMkU3/eD/zSNNWwMYgIK4l30AHEDQC+l2oJsCuSXD4d1QT00ovgULdmWTzywTJ6JS+ zQ1fa0F1dYpRM1Y16jntdVPlT6yJiiUFbg0FtJZiI3cGzTjXR2RxISV1Exx0t2dajL4g yP6gIhd+jjwdMFVnY2Xs0W8xPFyfhCrpd9SzcKblcNuJ7AnS5jFDQWjWxLCzJG3lsN+y APbA== X-Gm-Message-State: AOAM533VGx5wPHSwI4Ycttgc6vNk1w61wKYYtJW7swWm4LDxTzkqcjA1 xlqXVieWHPev4lBd0RLnTso= X-Google-Smtp-Source: ABdhPJy6tiBlS7Y9PEG2y6NKd0gtJct5hHGBgdFkw2WWZBgKIw/lQUaM7aC1rncE2M7LApgGvxxnRQ== X-Received: by 2002:a17:906:4787:b0:6f4:2f25:f9ff with SMTP id cw7-20020a170906478700b006f42f25f9ffmr27258921ejc.116.1653419334498; Tue, 24 May 2022 12:08:54 -0700 (PDT) Received: from kista.localnet (213-161-3-76.dynamic.telemach.net. [213.161.3.76]) by smtp.gmail.com with ESMTPSA id w9-20020a1709064a0900b006fed85c1a8fsm2777972eju.202.2022.05.24.12.08.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 May 2022 12:08:54 -0700 (PDT) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: mripard , wens , "benlypan@gmail.com" Cc: airlied , daniel , samuel , dri-devel , linux-arm-kernel , linux-sunxi , linux-kernel Subject: Re: Re: [PATCH] drm/sun4i: mixer: fix scanline for V3s and D1 Date: Tue, 24 May 2022 21:08:53 +0200 Message-ID: <4711779.GXAFRqVoOG@kista> In-Reply-To: <202205221848264427024@gmail.com> References: <20220521133443.1114749-1-benlypan@gmail.com> <3173956.44csPzL39Z@jernej-laptop> <202205221848264427024@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220524_120858_431377_CB9CCA72 X-CRM114-Status: GOOD ( 18.52 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Dne nedelja, 22. maj 2022 ob 12:48:27 CEST je benlypan@gmail.com napisal(a): > Hi Jernej! > > > Which SDK? All SDKs that I have or found on internet don't mention YUV nor RGB > > scanline limit. That doesn't mean there is none, I'm just unable to verify > > your claim. Did you test this by yourself? Also, please make YUV scanline > > change separate patch with fixes tag. > > Here is the code about scanline config for V3s: > https://github.com/Tina-Linux/tina-v3s-linux-4.9/blob/master/drivers/video/ fbdev/sunxi/disp2/disp/de/lowlevel_sun8iw8/de_feat.c#L55 > https://github.com/Tina-Linux/tina-v3s-linux-4.9/blob/master/drivers/video/ fbdev/sunxi/disp2/disp/de/lowlevel_sun8iw8/de_rtmx.c#L1212 > > And here is for D1: > https://gitlab.com/weidongshan/tina-d1-h/-/blob/main/lichee/linux-5.4/ drivers/video/fbdev/sunxi/disp2/disp/de/lowlevel_v2x/de_feat.c#L182 > https://gitlab.com/weidongshan/tina-d1-h/-/blob/main/lichee/linux-5.4/ drivers/video/fbdev/sunxi/disp2/disp/de/lowlevel_v2x/de_rtmx.c#L1588 Thanks for the links! > > I was tested it on V3s. Without this patch, the plane will not display > correctly if src_w large than 1024, for both YUV and RGB. I don't have a > device with D1, so D1 is not tested. But according to the SDK code of D1, > the scanline value of mixer1 is 1024. > > I'm new to submitting patches, So may I ask a question? If there is no > problem with this patch, what I need to do is to send new patches as you > suggested? https://www.kernel.org/doc/html/latest/process/submitting-patches.html I already requested changes, so you need to send v2. But wait until discussion is finished. Best regards, Jernej > > Best regards, > Genfu Pan > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9CED3C433F5 for ; Tue, 24 May 2022 19:08:57 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C0E3110E205; Tue, 24 May 2022 19:08:56 +0000 (UTC) Received: from mail-ej1-x62f.google.com (mail-ej1-x62f.google.com [IPv6:2a00:1450:4864:20::62f]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2AFD710E205 for ; Tue, 24 May 2022 19:08:56 +0000 (UTC) Received: by mail-ej1-x62f.google.com with SMTP id gh17so24236310ejc.6 for ; Tue, 24 May 2022 12:08:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=2OulZq3Irlc58uEaDk3npzMcuhHJigRPmtDLvl24/rI=; b=WyOcrh4LJIMo3HCPOQWirbN/TJkvHif36lLojpxyJDhYud5TualgotcCkgcTvRO/pq fX1q0MxY4T7EUloEsrlNE/ubBG25fPlKLtE+zICmsYR9xVa8f0DZQ/3XC/00d/ZrfBj5 7mjAAMXBwdKl4PzJmzUoqmFmmnuKiU6taXgjxER0By1YWVzrnw9+cfXMG3kuX9fW9+nZ H/pGzVoOP6cLrBSqzgjj71UYdJ5pstv9aa7alosWyvC1UzTvPQLrZD3+9UR+e6ggOa9h OeHRY9LY3AgoQUPrh4lnsrQwSO4hGnqeyP2gbTb7soQ6ieftA61Nf93Eig9+zZEDAu+H nTsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=2OulZq3Irlc58uEaDk3npzMcuhHJigRPmtDLvl24/rI=; b=pJbh0hWGluM5M5iB9FooXy9qFlhnJZns6zTKJicbNVNFCTsy31kEk/2mvHzWwo3U9D 2uIGUQNbwdJnd+TzbEjLnbD8mjJh/OzmSITq76ryexETuasyCeaPcQPHMrsk8lGqxN8v V+byf8jUFm1oq2uG1DPEGqbxx59mVCLnMCjci8JjtWJShFo7lWxZJmE/VP6XJGHivgR0 nMo0GV8V3EaxnuHzHmlJcVPNk0spEpNUc/Rq1EDGOcd+PyusIutmzmvb2WNl+3tt0AsM U66nBZU3vst6GWuW0pRvRsJdKGY0+57RPtu1DIQNL7g50czsJv0FK2ctBIr5spAWyN10 9GLA== X-Gm-Message-State: AOAM530YWIF2pjHlahc4OIGHy7wG0utl7NrQWi/O1rBv+Yugq5NCy6F4 Vk1drT/OWdX89D0eADgvlug= X-Google-Smtp-Source: ABdhPJy6tiBlS7Y9PEG2y6NKd0gtJct5hHGBgdFkw2WWZBgKIw/lQUaM7aC1rncE2M7LApgGvxxnRQ== X-Received: by 2002:a17:906:4787:b0:6f4:2f25:f9ff with SMTP id cw7-20020a170906478700b006f42f25f9ffmr27258921ejc.116.1653419334498; Tue, 24 May 2022 12:08:54 -0700 (PDT) Received: from kista.localnet (213-161-3-76.dynamic.telemach.net. [213.161.3.76]) by smtp.gmail.com with ESMTPSA id w9-20020a1709064a0900b006fed85c1a8fsm2777972eju.202.2022.05.24.12.08.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 May 2022 12:08:54 -0700 (PDT) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: mripard , wens , "benlypan@gmail.com" Subject: Re: Re: [PATCH] drm/sun4i: mixer: fix scanline for V3s and D1 Date: Tue, 24 May 2022 21:08:53 +0200 Message-ID: <4711779.GXAFRqVoOG@kista> In-Reply-To: <202205221848264427024@gmail.com> References: <20220521133443.1114749-1-benlypan@gmail.com> <3173956.44csPzL39Z@jernej-laptop> <202205221848264427024@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: samuel , airlied , linux-kernel , dri-devel , linux-sunxi , linux-arm-kernel Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Dne nedelja, 22. maj 2022 ob 12:48:27 CEST je benlypan@gmail.com napisal(a): > Hi Jernej! > > > Which SDK? All SDKs that I have or found on internet don't mention YUV nor RGB > > scanline limit. That doesn't mean there is none, I'm just unable to verify > > your claim. Did you test this by yourself? Also, please make YUV scanline > > change separate patch with fixes tag. > > Here is the code about scanline config for V3s: > https://github.com/Tina-Linux/tina-v3s-linux-4.9/blob/master/drivers/video/ fbdev/sunxi/disp2/disp/de/lowlevel_sun8iw8/de_feat.c#L55 > https://github.com/Tina-Linux/tina-v3s-linux-4.9/blob/master/drivers/video/ fbdev/sunxi/disp2/disp/de/lowlevel_sun8iw8/de_rtmx.c#L1212 > > And here is for D1: > https://gitlab.com/weidongshan/tina-d1-h/-/blob/main/lichee/linux-5.4/ drivers/video/fbdev/sunxi/disp2/disp/de/lowlevel_v2x/de_feat.c#L182 > https://gitlab.com/weidongshan/tina-d1-h/-/blob/main/lichee/linux-5.4/ drivers/video/fbdev/sunxi/disp2/disp/de/lowlevel_v2x/de_rtmx.c#L1588 Thanks for the links! > > I was tested it on V3s. Without this patch, the plane will not display > correctly if src_w large than 1024, for both YUV and RGB. I don't have a > device with D1, so D1 is not tested. But according to the SDK code of D1, > the scanline value of mixer1 is 1024. > > I'm new to submitting patches, So may I ask a question? If there is no > problem with this patch, what I need to do is to send new patches as you > suggested? https://www.kernel.org/doc/html/latest/process/submitting-patches.html I already requested changes, so you need to send v2. But wait until discussion is finished. Best regards, Jernej > > Best regards, > Genfu Pan > >