From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [Qemu-devel] [PATCH] Fix color problems with sdl on bgr displays Date: Sun, 14 Oct 2007 16:36:26 +0200 Message-ID: <4712296A.4030404@qumranet.com> References: <47121F0F.9020804@qumranet.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel , qemu-devel-qX2TKyscuCcdnm+yROfE0A@public.gmane.org To: Blue Swirl Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Blue Swirl wrote: > On 10/14/07, Avi Kivity wrote: > >> Some kvm users complained that the blue and red channels are flipped on >> their displays. Reverting sdl.c rev 1.40 fixed that problem, so >> apparently that commit made the problem larger than it was previously. >> >> Attached a patch the removes the commit and fixes the problem. Please >> apply. >> > > But this commit was previously reported as the best solution for OSX > (Intel, PPC) and Linux/PPC: > http://article.gmane.org/gmane.comp.emulators.qemu/18071 > > What kind of machines are the users using? > No idea, but I got two xdpyinfo logs and both indicated a bgr display. Perhaps we see here a difference between how SDL behaves on different platforms. Or maybe the test needs to be more subtle. I haven't had any reports of wrong colors before; of course kvm users don't run Linux/PPC os OSX/anything. -- error compiling committee.c: too many arguments to function ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/ From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Ih4ab-0007Zc-1A for qemu-devel@nongnu.org; Sun, 14 Oct 2007 10:37:09 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Ih4aX-0007Wp-H3 for qemu-devel@nongnu.org; Sun, 14 Oct 2007 10:37:08 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ih4aX-0007Wm-Cc for qemu-devel@nongnu.org; Sun, 14 Oct 2007 10:37:05 -0400 Received: from il.qumranet.com ([82.166.9.18]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Ih4aW-0007FH-Oz for qemu-devel@nongnu.org; Sun, 14 Oct 2007 10:37:05 -0400 Message-ID: <4712296A.4030404@qumranet.com> Date: Sun, 14 Oct 2007 16:36:26 +0200 From: Avi Kivity MIME-Version: 1.0 Subject: Re: [kvm-devel] [Qemu-devel] [PATCH] Fix color problems with sdl on bgr displays References: <47121F0F.9020804@qumranet.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: kvm-devel , qemu-devel@nongnu.org Blue Swirl wrote: > On 10/14/07, Avi Kivity wrote: > >> Some kvm users complained that the blue and red channels are flipped on >> their displays. Reverting sdl.c rev 1.40 fixed that problem, so >> apparently that commit made the problem larger than it was previously. >> >> Attached a patch the removes the commit and fixes the problem. Please >> apply. >> > > But this commit was previously reported as the best solution for OSX > (Intel, PPC) and Linux/PPC: > http://article.gmane.org/gmane.comp.emulators.qemu/18071 > > What kind of machines are the users using? > No idea, but I got two xdpyinfo logs and both indicated a bgr display. Perhaps we see here a difference between how SDL behaves on different platforms. Or maybe the test needs to be more subtle. I haven't had any reports of wrong colors before; of course kvm users don't run Linux/PPC os OSX/anything. -- error compiling committee.c: too many arguments to function