All of lore.kernel.org
 help / color / mirror / Atom feed
From: Franck Bui-Huu <vagabon.xyz@gmail.com>
To: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Cc: ralf@linux-mips.org, linux-mips@linux-mips.org
Subject: Re: [PATCH 1/4] tlbex.c: Cleanup __init usages.
Date: Sun, 14 Oct 2007 21:24:03 +0200	[thread overview]
Message-ID: <47126CD3.7020309@gmail.com> (raw)
In-Reply-To: <20071012.180742.59650681.nemoto@toshiba-tops.co.jp>

Atsushi Nemoto wrote:
> On Fri, 12 Oct 2007 08:41:18 +0200, Franck Bui-Huu <fbuihuu@gmail.com> wrote:
>>  #define I_0(op)							\
>> -	static inline void __init i##op(u32 **buf)		\
>> +	static inline void i##op(u32 **buf)		\
>>  	{							\
>>  		build_insn(buf, insn##op);			\
>>  	}
> 
> This causes section mismatches, since i_tlbwr and i_tlbwi can not be
> inlined (see head of build_tlb_write_entry()).
> 

You're right. I compiled tlbex.o alone and missed that.

> Maybe __init __maybe_unused is preferred?
> 

Yes I'll do that.

Thanks,
		Franck

  parent reply	other threads:[~2007-10-14 19:25 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-12  6:39 [PATCH 0/4] Cleanup tlbex.c Franck Bui-Huu
2007-10-12  6:41 ` [PATCH 1/4] tlbex.c: Cleanup __init usages Franck Bui-Huu
2007-10-12  9:07   ` Atsushi Nemoto
2007-10-12 16:01     ` Johannes Dickgreber
2007-10-14 19:24     ` Franck Bui-Huu [this message]
2007-10-12  6:42 ` [PATCH 2/4] tlbex.c: cleanup include files Franck Bui-Huu
2007-10-12  6:43 ` [PATCH 3/4] tlbex.c: cleanup debug code Franck Bui-Huu
2007-10-12 17:11   ` Thiemo Seufer
2007-10-14 20:20     ` Franck Bui-Huu
2007-10-12  6:43 ` [PATCH 4/4] tlbex.c: use __cacheline_aligned instead of __tlb_handler_align attribute Franck Bui-Huu
  -- strict thread matches above, loose matches on Subject: below --
2007-10-18  7:11 [PATCH 0/4] tlbex.c: trivial cleanup [take #2] Franck Bui-Huu
2007-10-18  7:11 ` [PATCH 1/4] tlbex.c: Cleanup __init usages Franck Bui-Huu
2007-11-06 13:47   ` Ralf Baechle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47126CD3.7020309@gmail.com \
    --to=vagabon.xyz@gmail.com \
    --cc=anemo@mba.ocn.ne.jp \
    --cc=linux-mips@linux-mips.org \
    --cc=ralf@linux-mips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.