All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Krufky <mkrufky@linuxtv.org>
To: Adrian Bunk <bunk@kernel.org>
Cc: Mauro Carvalho Chehab <mchehab@infradead.org>,
	v4l-dvb-maintainer@linuxtv.org, linux-kernel@vger.kernel.org
Subject: Re: tuner-core.c:fe_has_signal() can returne uninitialized value
Date: Sun, 14 Oct 2007 17:16:08 -0400	[thread overview]
Message-ID: <47128718.2070603@linuxtv.org> (raw)
In-Reply-To: <20071014175159.GO4211@stusta.de>

Adrian Bunk wrote:
> Commit 1f5ef19779df2c2f75870332b37dd3004c08a515 added the following 
> function to drivers/media/video/tuner-core.c:
>
> <--  snip  -->
>
> static int fe_has_signal(struct tuner *t)
> {
>         struct dvb_tuner_ops *fe_tuner_ops = &t->fe.ops.tuner_ops;
>         u16 strength;
>
>         if (fe_tuner_ops->get_rf_strength)
>                 fe_tuner_ops->get_rf_strength(&t->fe, &strength);
>
>         return strength;
> }
>
> <--  snip  -->
>
>
> If (!fe_tuner_ops->get_rf_strength) this function returns the value of 
> an uninitialized variable.
>
> Spotted by the Coverity checker.
>   
Thank you, Adrian.  I've fixed this in my tree:

http://linuxtv.org/hg/~mkrufky/v4l-dvb/rev/101ca558a777

Mauro, please pull from:

http://linuxtv.org/hg/~mkrufky/v4l-dvb

for:

- tuner-core.c: fe_has_signal() can return uninitialized value

 tuner-core.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Please send this to Linus for 2.6.24

Regards,

Mike

      reply	other threads:[~2007-10-14 21:16 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-14 17:51 tuner-core.c:fe_has_signal() can returne uninitialized value Adrian Bunk
2007-10-14 21:16 ` Michael Krufky [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47128718.2070603@linuxtv.org \
    --to=mkrufky@linuxtv.org \
    --cc=bunk@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mchehab@infradead.org \
    --cc=v4l-dvb-maintainer@linuxtv.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.