All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: lizf <lizf@cn.fujitsu.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH 1/2] netfilter: fix - mistake to pass a pointer where array is required
Date: Mon, 15 Oct 2007 08:07:14 +0200	[thread overview]
Message-ID: <47130392.60902@trash.net> (raw)
In-Reply-To: <470F09EF.9080606@cn.fujitsu.com>

lizf wrote:
> Hi,
> 
> Macros like SCTP_CHUNKMAP_XXX(chukmap) require chukmap to be an array,
> We can see from below:
> 
> #define ELEMCOUNT(x) (sizeof(x)/sizeof(x[0]))
> 
> #define SCTP_CHUNKMAP_RESET(chunkmap)                \
>     do {                            \
>         int i;                        \
>         for (i = 0; i < ELEMCOUNT(chunkmap); i++)    \
>             chunkmap[i] = 0;            \
>     } while (0)
> 
> But match_packet() passes a pointer to these macros. Here's the patch.
> 
> Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>


Thanks, but your mailer corrupted the patch by converting tabs to
spaces. Please resend as attachment so I can apply it.



  reply	other threads:[~2007-10-15  6:07 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-12  5:45 [PATCH 1/2] netfilter: fix - mistake to pass a pointer where array is required lizf
2007-10-15  6:07 ` Patrick McHardy [this message]
2007-10-15 10:00   ` lizf
2007-10-18  9:01     ` Patrick McHardy
2007-10-18  9:05       ` Patrick McHardy
2007-10-18  9:14         ` lizf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47130392.60902@trash.net \
    --to=kaber@trash.net \
    --cc=lizf@cn.fujitsu.com \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.