From: Jeff Garzik <jeff@garzik.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Ingo Molnar <mingo@elte.hu>,
linux-kernel@vger.kernel.org, Boaz Harrosh <bharrosh@panasas.com>,
James Bottomley <James.Bottomley@SteelEye.com>
Subject: Re: [patch] scsi: fix crash in gdth_timeout()
Date: Mon, 15 Oct 2007 13:57:14 -0400 [thread overview]
Message-ID: <4713A9FA.4050209@garzik.org> (raw)
In-Reply-To: <alpine.LFD.0.999.0710151006400.6887@woody.linux-foundation.org>
Linus Torvalds wrote:
>
> On Mon, 15 Oct 2007, Ingo Molnar wrote:
>> A further problem is probably that the GDTH timer is not stopped by a
>> failed GDTH probe?
>
> Indeed. Maybe this is a better fix?
>
> That driver is pretty messy, and this should have been found ealier.
> James? Boaz?
FWIW, the gdth driver was "super-messy". With this latest SCSI pull,
that severity has been successfully downgraded to "messy" :)
IMO some easy-to-fix breakage was inevitable with such a large volume of
fundamental changes.
Honestly, the driver is probably rarely run by people that lack the
hardware, I bet...
Jeff
next prev parent reply other threads:[~2007-10-15 17:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-15 16:55 [patch] scsi: fix crash in gdth_timeout() Ingo Molnar
2007-10-15 17:08 ` Linus Torvalds
2007-10-15 17:57 ` Jeff Garzik [this message]
2007-10-15 18:43 ` Boaz Harrosh
2007-10-15 19:27 ` Ingo Molnar
2007-10-15 19:38 ` Linus Torvalds
2007-10-15 20:08 ` Alan Cox
2007-10-15 20:15 ` Linus Torvalds
2007-10-15 22:23 ` Ingo Molnar
2007-10-15 19:24 ` Ingo Molnar
2007-10-15 21:55 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4713A9FA.4050209@garzik.org \
--to=jeff@garzik.org \
--cc=James.Bottomley@SteelEye.com \
--cc=bharrosh@panasas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.