From: Patrick McHardy <kaber@trash.net>
To: Petr Pisar <petr.pisar@atlas.cz>
Cc: netfilter@vger.kernel.org,
Netfilter Development Mailinglist
<netfilter-devel@vger.kernel.org>
Subject: Re: [ANNOUNCE] Release of iptables 1.4.0rc1
Date: Tue, 16 Oct 2007 10:44:37 +0200 [thread overview]
Message-ID: <471479F5.4000002@trash.net> (raw)
In-Reply-To: <slrnfh7f7l.crr.petr.pisar@album.ics.muni.cz>
[-- Attachment #1: Type: text/plain, Size: 482 bytes --]
Please CC netfilter-devel on bugreports.
Petr Pisar wrote:
> On 2007-10-15, Pablo Neira Ayuso <pablo@netfilter.org> wrote:
>> The netfilter coreteam proudly presents:
>>
>> iptables version 1.4.0rc1
>>
> Great to hear it. But it doesn't build ip6tables-{save,restore} as older
> versions either. The problem is that these two makefile targets are in
> *_EXP veriable.
>
> It is bug or a feature?
I would say its a bug. I've added this patch, please test if it works
for you.
[-- Attachment #2: x --]
[-- Type: text/plain, Size: 1547 bytes --]
Index: ip6tables-restore.c
===================================================================
--- ip6tables-restore.c (Revision 7068)
+++ ip6tables-restore.c (Arbeitskopie)
@@ -77,7 +77,11 @@
static int parse_counters(char *string, struct ip6t_counters *ctr)
{
- return (sscanf(string, "[%llu:%llu]", (unsigned long long *)&ctr->pcnt, (unsigned long long *)&ctr->bcnt) == 2);
+ u_int64_t *pcnt, *bcnt;
+
+ pcnt = &ctr->pcnt;
+ bcnt = &ctr->bcnt;
+ return (sscanf(string, "[%llu:%llu]", (unsigned long long *)pcnt, (unsigned long long *)bcnt) == 2);
}
/* global new argv and argc */
Index: Makefile
===================================================================
--- Makefile (Revision 7068)
+++ Makefile (Arbeitskopie)
@@ -61,8 +61,8 @@
ifeq ($(DO_IPV6), 1)
EXTRAS+=ip6tables ip6tables.o ip6tables.8
EXTRA_INSTALLS+=$(DESTDIR)$(BINDIR)/ip6tables $(DESTDIR)$(MANDIR)/man8/ip6tables.8
-EXTRAS_EXP+=ip6tables-save ip6tables-restore
-EXTRA_INSTALLS_EXP+=$(DESTDIR)$(BINDIR)/ip6tables-save $(DESTDIR)$(BINDIR)/ip6tables-restore # $(DESTDIR)$(MANDIR)/man8/iptables-restore.8 $(DESTDIR)$(MANDIR)/man8/iptables-save.8 $(DESTDIR)$(MANDIR)/man8/ip6tables-save.8 $(DESTDIR)$(MANDIR)/man8/ip6tables-restore.8
+EXTRAS+=ip6tables-save ip6tables-restore
+EXTRA_INSTALLS+=$(DESTDIR)$(BINDIR)/ip6tables-save $(DESTDIR)$(BINDIR)/ip6tables-restore # $(DESTDIR)$(MANDIR)/man8/iptables-restore.8 $(DESTDIR)$(MANDIR)/man8/iptables-save.8 $(DESTDIR)$(MANDIR)/man8/ip6tables-save.8 $(DESTDIR)$(MANDIR)/man8/ip6tables-restore.8
endif
ifndef IPT_LIBDIR
next prev parent reply other threads:[~2007-10-16 8:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-15 16:52 [ANNOUNCE] Release of iptables 1.4.0rc1 Pablo Neira Ayuso
2007-10-15 19:18 ` Petr Pisar
2007-10-15 21:35 ` Robby Workman
2007-10-16 8:44 ` Patrick McHardy [this message]
2007-10-16 14:30 ` Petr Pisar
2007-10-17 8:48 ` Patrick McHardy
2007-10-16 15:01 ` Jan Engelhardt
2007-10-17 8:38 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=471479F5.4000002@trash.net \
--to=kaber@trash.net \
--cc=netfilter-devel@vger.kernel.org \
--cc=netfilter@vger.kernel.org \
--cc=petr.pisar@atlas.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.