From: Laszlo Attila Toth <panther@balabit.hu>
To: Patrick McHardy <kaber@trash.net>
Cc: netdev@vger.kernel.org, netfilter-devel@vger.kernel.org
Subject: Re: [PATCH 2/2] Interface group match - netfilter part
Date: Tue, 16 Oct 2007 11:46:24 +0200 [thread overview]
Message-ID: <47148870.3010107@balabit.hu> (raw)
In-Reply-To: <47147692.8070709@trash.net>
Patrick McHardy írta:
> Laszlo Attila Toth wrote:
>> +static int match(const struct sk_buff *skb,
>> + const struct net_device *in,
>> + const struct net_device *out,
>> + const struct xt_match *match,
>> + const void *matchinfo,
>> + int offset,
>> + unsigned int protoff,
>> + int *hotdrop)
>> +{
>> + const struct xt_ifgroup_info *info = matchinfo;
>> +
>> + return ((in->ifgroup & info->mask) == info->group) ^ info->invert;
>
> The input interface is only valid in PREROUTING, INPUT and FORWARD.
> Why don't you support output-interface matching?
>
It has no specific reason. I'll make it with the other changes you
wrote. I'll send the iptables patch at the same time.
--
Attila
-
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2007-10-16 9:46 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-16 8:01 [PATCH 0/2] Interface groups Laszlo Attila Toth
2007-10-16 8:01 ` Laszlo Attila Toth
2007-10-16 8:50 ` Philip Craig
2007-10-16 9:47 ` Laszlo Attila Toth
2007-10-16 8:01 ` [PATCH 1/2] Interface group: core (netlink) part Laszlo Attila Toth
2007-10-16 8:01 ` Laszlo Attila Toth
2007-10-16 8:34 ` Patrick McHardy
2007-10-16 8:01 ` [PATCH 2/2] Interface group match - netfilter part Laszlo Attila Toth
2007-10-16 8:01 ` Laszlo Attila Toth
2007-10-16 8:30 ` Patrick McHardy
2007-10-16 9:46 ` Laszlo Attila Toth [this message]
2007-10-16 14:46 ` Jan Engelhardt
2007-10-17 9:08 ` Laszlo Attila Toth
2007-10-17 9:11 ` Patrick McHardy
2007-10-16 8:01 ` [IPROUTE2 PATCH] Interface group as new ip link option Laszlo Attila Toth
2007-10-16 8:01 ` Laszlo Attila Toth
2007-10-16 8:38 ` Patrick McHardy
2007-10-16 9:33 ` Laszlo Attila Toth
2007-10-16 9:03 ` Resend: " Laszlo Attila Toth
2007-10-16 9:11 ` Patrick McHardy
2007-10-16 10:45 ` jamal
2007-10-16 11:05 ` Laszlo Attila Toth
2007-10-16 11:26 ` jamal
2007-10-16 11:47 ` Laszlo Attila Toth
2007-10-16 12:08 ` jamal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47148870.3010107@balabit.hu \
--to=panther@balabit.hu \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.