From: Jerry Van Baren <gerald.vanbaren@ge.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [Patch] Make MPC8266ADS compile again
Date: Tue, 16 Oct 2007 16:01:51 -0400 [thread overview]
Message-ID: <471518AF.8080509@ge.com> (raw)
In-Reply-To: <47151610.47FrR7hZ3a0AxzYl%runet@innovsys.com>
runet at innovsys.com wrote:
> Make MPC8266ADS board compile again.
> Signed-off-by: Runet Torgersen <runet@innovsys.com>
>
> diff --git a/include/configs/MPC8266ADS.h b/include/configs/MPC8266ADS.h
> index 14b041e..d392b98 100644
> --- a/include/configs/MPC8266ADS.h
> +++ b/include/configs/MPC8266ADS.h
> @@ -168,6 +168,7 @@
> #undef CONFIG_CMD_MFSL
> #undef CONFIG_CMD_MMC
> #undef CONFIG_CMD_NAND
> +#undef CONFIG_CMD_ONENAND
> #undef CONFIG_CMD_PCMCIA
> #undef CONFIG_CMD_REISER
> #undef CONFIG_CMD_SCSI
> @@ -177,6 +178,7 @@
> #undef CONFIG_CMD_UNIVERSE
> #undef CONFIG_CMD_USB
> #undef CONFIG_CMD_XIMG
> +#undef CONFIG_CMD_AT91_SPIMUX
>
> /* Define a command string that is automatically executed when no character
> * is read on the console interface withing "Boot Delay" after reset.
The *proper* fix is to delete the
#include <config_cmd_all.h>
and #define only the commands that actually are desired.
The simplest (and probably most proper) way to do this is actually to
#include <config_cmd_default.h>
and then add non-default commands that may be useful on the MPC8266ADS
board.
The current configuration is legacy from the old bit-mapped
configuration ways plus a very poor choice to do the "all-subtractive"
method of selecting commands.
With the "all-subtractive" method, new commands will *FOREVER* be
breaking the board, resulting in patches and/or bit rot forever. Please
fix it once, right, and we will all thank you forever.
TIA,
gvb
next prev parent reply other threads:[~2007-10-16 20:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-16 19:50 [U-Boot-Users] [Patch] Make MPC8266ADS compile again runet at innovsys.com
2007-10-16 20:01 ` Jerry Van Baren [this message]
2007-10-16 20:33 ` Wolfgang Denk
2007-10-16 20:33 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=471518AF.8080509@ge.com \
--to=gerald.vanbaren@ge.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.