From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Denis V. Lunev" Subject: Re: [PATCH] [NETNS49] support for per/namespace routing cache cleanup Date: Wed, 17 Oct 2007 21:56:13 +0400 Message-ID: <47164CBD.3040107@gmail.com> References: <20071017111215.GA29653@iris.sw.ru> <4715F60F.6060304@fr.ibm.com> <4716055D.4010102@sw.ru> <471610E8.8020008@fr.ibm.com> <471617CA.9090901@sw.ru> <471624C0.9020108@fr.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <471624C0.9020108-NmTC/0ZBporQT0dZR+AlfA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Daniel Lezcano Cc: Linux Containers , "Denis V. Lunev" , ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org, Benjamin Thery List-Id: containers.vger.kernel.org Daniel Lezcano wrote: > Oh, by the way, I forgot something important you spotted with the list > protected by the mutex. > > When looking at ipv6/fib_hash.c with Benjamin, we need to browse the > network namespaces list for the garbage collecting, but we are in an > interrupt handler, so I can not use rtnl_lock. where exactly.... all interesting places are called under rtnl already... > Why is not possible to protect the list with a simple spinlock ? so we > can call spin_lock_bh when we are in interrupt handler. see my old patch with a locking rules :) By the way, I have forgotten to mention, that the original patch works from 2004 for OpenVz :) Regards, Den