From: Jeff Garzik <jgarzik@pobox.com>
To: Don Fry <pcnet32@verizon.net>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] pcnet32: fix non-napi packet reception
Date: Wed, 17 Oct 2007 20:21:57 -0400 [thread overview]
Message-ID: <4716A725.2030800@pobox.com> (raw)
In-Reply-To: <1192661962.474.10.camel@Linux.home>
Don Fry wrote:
> Recent changes to the driver for the new napi API broke the reception of packets when in
> non-napi mode. The initialization of napi.weight was removed for the non-napi case
> leaving the value zero.
>
> Tested NAPI and non-NAPI on x86_64.
>
> Signed-off-by: Don Fry <pcnet32@verizon.net>
> ---
> --- linux-2.6.23-git7/drivers/net/orig.pcnet32.c 2007-10-15 11:19:17.000000000 -0700
> +++ linux-2.6.23-git7/drivers/net/pcnet32.c 2007-10-17 15:56:15.000000000 -0700
> @@ -1849,6 +1849,9 @@ pcnet32_probe1(unsigned long ioaddr, int
> lp->mii_if.mdio_read = mdio_read;
> lp->mii_if.mdio_write = mdio_write;
>
> + /* napi.weight is used in both the napi and non-napi cases */
> + lp->napi.weight = lp->rx_ring_size / 2;
> +
> #ifdef CONFIG_PCNET32_NAPI
> netif_napi_add(dev, &lp->napi, pcnet32_poll, lp->rx_ring_size / 2);
> #endif
applied
next prev parent reply other threads:[~2007-10-18 0:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-17 22:59 [PATCH] pcnet32: fix non-napi packet reception Don Fry
2007-10-17 23:55 ` Jeff Garzik
2007-10-18 0:21 ` Jeff Garzik [this message]
-- strict thread matches above, loose matches on Subject: below --
2007-10-18 0:04 Don Fry
2007-10-18 19:23 ` Lennart Sorensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4716A725.2030800@pobox.com \
--to=jgarzik@pobox.com \
--cc=netdev@vger.kernel.org \
--cc=pcnet32@verizon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.