From: Jeff Garzik <jeff@garzik.org>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: linux-ide@vger.kernel.org, akpm@osdl.org
Subject: Re: [PATCH] libata-sff: Correct use of check_status()
Date: Wed, 17 Oct 2007 20:58:50 -0400 [thread overview]
Message-ID: <4716AFCA.4080509@garzik.org> (raw)
In-Reply-To: <20071015192529.2365b636@the-village.bc.nu>
Alan Cox wrote:
> ata_check_status() does an SFF compliant check
> ata_chk_status() does a generic call to ap->ops->check_status (usually
> ata_check_status)
>
> libata-sff uses the wrong one. Hardly suprising given the naming here,
> which ought to get fixed to ata_sff_check_status() perhaps ?
>
> Signed-off-by: Alan Cox <alan@redhat.com>
>
> diff -u --exclude-from /usr/src/exclude --new-file --recursive linux.vanilla-2.6.23-mm1/drivers/ata/libata-sff.c linux-2.6.23-mm1/drivers/ata/libata-sff.c
> --- linux.vanilla-2.6.23-mm1/drivers/ata/libata-sff.c 2007-10-15 15:03:26.000000000 +0100
> +++ linux-2.6.23-mm1/drivers/ata/libata-sff.c 2007-10-15 15:16:29.000000000 +0100
> @@ -156,7 +156,7 @@
> {
> struct ata_ioports *ioaddr = &ap->ioaddr;
>
> - tf->command = ata_check_status(ap);
> + tf->command = ata_chk_status(ap);
> tf->feature = ioread8(ioaddr->error_addr);
> tf->nsect = ioread8(ioaddr->nsect_addr);
> tf->lbal = ioread8(ioaddr->lbal_addr);
applied, with a sigh: it's in SFF, so I saw nothing wrong with
ata_check_status(). I checked -- no SFF driver overrides it according
to my audit, therefore the previous version was faster while still correct.
next prev parent reply other threads:[~2007-10-18 0:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-15 18:25 [PATCH] libata-sff: Correct use of check_status() Alan Cox
2007-10-18 0:58 ` Jeff Garzik [this message]
2007-10-22 10:40 ` Alan Cox
2007-10-22 18:36 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4716AFCA.4080509@garzik.org \
--to=jeff@garzik.org \
--cc=akpm@osdl.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.