From: Mark Lord <lkml@rtr.ca>
To: kristen.c.accardi@intel.com
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
"Theodore Ts'o" <tytso@mit.edu>,
greg@kroah.com, pcihpd-discuss@lists.sourceforge.net
Subject: [PATCH 3/3] pciehp: hotplug: reinit hotplug h/w on resume from suspend
Date: Wed, 17 Oct 2007 23:34:59 -0400 [thread overview]
Message-ID: <4716D463.2010306@rtr.ca> (raw)
In-Reply-To: <4716D415.6010904@rtr.ca>
(repost to conform with akpm's subject line conventions)
Make use of the previously split out pcie_init_enable_events() function
to reinitialize the hotplug hardware on resume from suspend,
but only when pciehp_force==1. Otherwise behaviour is unmodified.
Signed-off-by: Mark Lord <mlord@pobox.com>
---
--- git12/drivers/pci/hotplug/pciehp_ctrl.c 2007-10-17 19:28:23.000000000 -0400
+++ linux/drivers/pci/hotplug/pciehp_ctrl.c 2007-10-17 19:31:22.000000000 -0400
@@ -37,7 +37,6 @@
#include "pciehp.h"
static void interrupt_event_handler(struct work_struct *work);
-static int pciehp_disable_slot(struct slot *p_slot);
static int queue_interrupt_event(struct slot *p_slot, u32 event_type)
{
--- git12/drivers/pci/hotplug/pciehp.h 2007-10-17 19:28:23.000000000 -0400
+++ linux/drivers/pci/hotplug/pciehp.h 2007-10-17 19:32:03.000000000 -0400
@@ -162,6 +162,8 @@
extern void pciehp_queue_pushbutton_work(struct work_struct *work);
int pcie_init(struct controller *ctrl, struct pcie_device *dev);
int pciehp_enable_slot(struct slot *p_slot);
+int pciehp_disable_slot(struct slot *p_slot);
+int pcie_init_hardware(struct controller *ctrl, struct pcie_device *dev);
static inline struct slot *pciehp_find_slot(struct controller *ctrl, u8 device)
{
--- git12/drivers/pci/hotplug/pciehp_core.c 2007-10-17 19:28:23.000000000 -0400
+++ linux/drivers/pci/hotplug/pciehp_core.c 2007-10-17 19:33:05.000000000 -0400
@@ -510,6 +510,24 @@
static int pciehp_resume (struct pcie_device *dev)
{
printk("%s ENTRY\n", __FUNCTION__);
+ if (pciehp_force) {
+ struct pci_dev *pdev = dev->port;
+ struct controller *ctrl = pci_get_drvdata(pdev);
+ struct slot *t_slot;
+ u8 status;
+
+ /* reinitialize the chipset's event detection logic */
+ pcie_init_hardware(ctrl, dev);
+
+ t_slot = pciehp_find_slot(ctrl, ctrl->slot_device_offset);
+
+ /* Check if slot is occupied */
+ t_slot->hpc_ops->get_adapter_status(t_slot, &status);
+ if (status)
+ pciehp_enable_slot(t_slot);
+ else
+ pciehp_disable_slot(t_slot);
+ }
return 0;
}
#endif
next prev parent reply other threads:[~2007-10-18 3:35 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-18 2:57 [PATCH 0/3] Fix two PEIe hotplug issues Mark Lord
2007-10-18 2:59 ` [PATCH 1/3] pciehp_handle_preinserted_card Mark Lord
2007-10-18 3:00 ` [PATCH 2/3] pciehp_split_pcie_init Mark Lord
2007-10-18 3:02 ` [PATCH 3/3] pciehp_resume_reinit_hardware Mark Lord
2007-10-18 3:03 ` [PATCH 1/3] pciehp_handle_preinserted_card Mark Lord
2007-10-18 3:04 ` [PATCH 2/3] pciehp_split_pcie_init Mark Lord
2007-10-18 3:05 ` [PATCH 0/3] Fix two PEIe hotplug issues Mark Lord
2007-10-18 3:09 ` Mark Lord
2007-10-18 16:13 ` Kristen Carlson Accardi
2007-10-18 17:06 ` Mark Lord
2007-10-18 17:06 ` Kristen Carlson Accardi
2007-10-18 17:49 ` Theodore Tso
2007-10-18 17:56 ` Kristen Carlson Accardi
2007-10-18 21:11 ` Mark Lord
2007-10-18 21:26 ` Mark Lord
2007-10-18 3:32 ` [PATCH 1/3] pciehp: hotplug: deal with pre-inserted ExpressCards Mark Lord
2007-10-18 3:33 ` [PATCH 2/3] pciehp: hotplug: split out hardware init from pcie_init() Mark Lord
2007-10-18 3:34 ` Mark Lord [this message]
2007-10-18 11:15 ` [Pcihpd-discuss] [PATCH 1/3] pciehp: hotplug: deal with pre-inserted ExpressCards Kenji Kaneshige
2007-10-18 13:31 ` Mark Lord
2007-10-19 2:38 ` Kenji Kaneshige
2007-10-19 3:09 ` Mark Lord
2007-10-19 3:27 ` Kenji Kaneshige
2007-11-18 0:27 ` [PATCH] Fix PCIe double initialization bug Mark Lord
2007-11-18 12:23 ` Rafael J. Wysocki
2007-11-18 14:20 ` Mark Lord
2007-11-18 14:37 ` Mark Lord
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4716D463.2010306@rtr.ca \
--to=lkml@rtr.ca \
--cc=akpm@linux-foundation.org \
--cc=greg@kroah.com \
--cc=kristen.c.accardi@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pcihpd-discuss@lists.sourceforge.net \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.