From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1IiWpF-000177-S2 for mharc-grub-devel@gnu.org; Thu, 18 Oct 2007 10:58:17 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IiWpE-000172-Ty for grub-devel@gnu.org; Thu, 18 Oct 2007 10:58:16 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IiWpC-00016h-Fz for grub-devel@gnu.org; Thu, 18 Oct 2007 10:58:15 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IiWpC-00016c-Dp for grub-devel@gnu.org; Thu, 18 Oct 2007 10:58:14 -0400 Received: from pne-smtpout4-sn2.hy.skanova.net ([81.228.8.154]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1IiWpC-0008GI-0B for grub-devel@gnu.org; Thu, 18 Oct 2007 10:58:14 -0400 Received: from [127.0.0.1] (88.193.32.97) by pne-smtpout4-sn2.hy.skanova.net (7.2.075) id 45B6216900CC0C88 for grub-devel@gnu.org; Thu, 18 Oct 2007 16:58:13 +0200 Message-ID: <47177489.3060607@nic.fi> Date: Thu, 18 Oct 2007 17:58:17 +0300 From: =?UTF-8?B?VmVzYSBKw6TDpHNrZWzDpGluZW4=?= User-Agent: Thunderbird 2.0.0.6 (Windows/20070728) MIME-Version: 1.0 To: The development of GRUB 2 References: <20071017084431.GA17289@thorin> <471651D2.3010600@nic.fi> <20071017194526.GA23951@thorin> In-Reply-To: <20071017194526.GA23951@thorin> X-Enigmail-Version: 0.95.3 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: Quoted-Printable X-detected-kernel: by monty-python.gnu.org: Solaris 8 (1) Subject: Re: [PATCH] split i386-generic part of i386/pc/loader.h X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Oct 2007 14:58:17 -0000 Robert Millan wrote: > On Wed, Oct 17, 2007 at 09:17:54PM +0300, Vesa J=C3=A4=C3=A4skel=C3=A4i= nen wrote: >> Robert Millan wrote: >>> This patch splits the i386-generic part of i386/pc/loader.h into i386= /loader.h. >>> >>> Comments? >> Why did you move stuff from i386/pc to i386 ? >> >> I do see a point on running grub2 on non-pc i386... >=20 > It's for LinuxBIOS. >=20 If this is some new arch that will be supported on i386 then I would suggest i386/linuxbios/. I think the question to be asked here is that does all i386 architectures need this functionality that you extracted. I have nothing against modularizing code, in example if you compare contents of the efi and pc directories you will notice that efi does not need most of the stuff that is present on pc. Actually I think better name for pc would be pcbios... If you want to share code with LinuxBIOS why not just share those files located on i386/pc/.