From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeremy Fitzhardinge Subject: Re: unregister_xenbus_watch() handling of xenwatch_mutex Date: Thu, 18 Oct 2007 09:02:01 -0700 Message-ID: <47178379.8040702@goop.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Keir Fraser Cc: xen-devel@lists.xensource.com, Jeremy Fitzhardinge , Jan Beulich List-Id: xen-devel@lists.xenproject.org Keir Fraser wrote: > That's a question for Jeremy. I think the 2.6.18 version is equally correct > and only needs one if statement. Maybe hoisting the lock acquisition gave > Jeremy a warmer fuzzy feeling? :-) > I don't remember changing this specifically. It might have been in response to a review comment, or maybe xen-unstable changed since I grabbed the code... J