From: Andreas Ericsson <ae@op5.se>
To: "Shawn O. Pearce" <spearce@spearce.org>
Cc: David Symonds <dsymonds@gmail.com>, Jeff King <peff@peff.net>,
git@vger.kernel.org
Subject: Re: [RFC/PATCH] git-fetch: mega-terse fetch output
Date: Fri, 19 Oct 2007 12:51:06 +0200 [thread overview]
Message-ID: <47188C1A.2090600@op5.se> (raw)
In-Reply-To: <20071019073938.GN14735@spearce.org>
Shawn O. Pearce wrote:
>
> +static void determine_window_size(void)
> +{
> + struct winsize ws;
> + if (!ioctl(2, TIOCGWINSZ, &ws))
> + ws_cols = ws.ws_col;
> +}
> +
I'd suggest re-using term_columns() from help.c instead. It's been in there
since the git wrapper was rewritten in C, so it's had a bit of testing and
seems to work fairly well.
--
Andreas Ericsson andreas.ericsson@op5.se
OP5 AB www.op5.se
Tel: +46 8-230225 Fax: +46 8-230231
next prev parent reply other threads:[~2007-10-19 10:54 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-19 6:22 [RFC/PATCH] git-fetch: mega-terse fetch output Jeff King
2007-10-19 6:39 ` David Symonds
2007-10-19 6:46 ` Jeff King
2007-10-19 7:39 ` Shawn O. Pearce
2007-10-19 7:57 ` Jeff King
2007-10-19 8:07 ` Shawn O. Pearce
2007-10-19 8:11 ` Jeff King
[not found] ` <?= =?ISO-8859-1?Q?2007101=049081127.?= =?ISO-8859-1?Q?GA30168@coredump?= =?ISO-8859-1?Q?.intra.peff.net>
2007-10-19 8:19 ` David Kastrup
2007-10-19 8:39 ` Jeff King
2007-10-19 8:21 ` Johannes Sixt
2007-10-19 10:03 ` Santi Béjar
2007-10-19 11:38 ` Theodore Tso
2007-10-19 12:31 ` Johannes Sixt
2007-10-19 14:14 ` Nicolas Pitre
2007-10-19 14:31 ` Johannes Schindelin
2007-10-19 14:31 ` Santi Béjar
2007-10-19 14:40 ` Karl Hasselström
2007-10-19 14:40 ` Johannes Sixt
2007-10-19 14:54 ` Nicolas Pitre
2007-10-19 14:41 ` Johannes Schindelin
2007-10-19 14:56 ` Nicolas Pitre
2007-10-19 14:52 ` Nicolas Pitre
2007-10-20 5:00 ` Jeff King
2007-10-20 6:58 ` Shawn O. Pearce
2007-10-19 14:38 ` Karl Hasselström
2007-10-19 15:03 ` Nicolas Pitre
2007-10-19 21:17 ` Theodore Tso
2007-10-19 21:40 ` Nicolas Pitre
2007-10-19 21:58 ` Theodore Tso
2007-10-19 13:15 ` Nicolas Pitre
2007-10-23 8:39 ` Miles Bader
2007-10-19 10:45 ` Andreas Ericsson
2007-10-19 10:51 ` Andreas Ericsson [this message]
2007-10-19 13:05 ` Nicolas Pitre
2007-10-19 15:50 ` Steven Grimm
2007-10-19 15:53 ` Steven Grimm
2007-10-19 16:12 ` Nicolas Pitre
2007-10-19 17:26 ` Sam Ravnborg
2007-10-19 18:51 ` Nicolas Pitre
2007-10-19 10:40 ` Andreas Ericsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47188C1A.2090600@op5.se \
--to=ae@op5.se \
--cc=dsymonds@gmail.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.