From: Eric Sandeen <sandeen@redhat.com>
To: ext4 development <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH] provide missing mode for open-create in check_mntent_file
Date: Fri, 19 Oct 2007 15:15:36 -0500 [thread overview]
Message-ID: <47191068.2010609@redhat.com> (raw)
In-Reply-To: <46C4D18E.3080509@redhat.com>
Eric Sandeen wrote:
> F8 is catching opens with O_CREAT flags and no mode now, and refusing
> to build them...
Ping? I don't see this in git yet.
Thanks,
-Eric
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
>
> Index: e2fsprogs-git/lib/ext2fs/ismounted.c
> ===================================================================
> --- e2fsprogs-git.orig/lib/ext2fs/ismounted.c
> +++ e2fsprogs-git/lib/ext2fs/ismounted.c
> @@ -147,7 +147,7 @@ static errcode_t check_mntent_file(const
> is_root:
> #define TEST_FILE "/.ismount-test-file"
> *mount_flags |= EXT2_MF_ISROOT;
> - fd = open(TEST_FILE, O_RDWR|O_CREAT);
> + fd = open(TEST_FILE, O_RDWR|O_CREAT, 0644);
> if (fd < 0) {
> if (errno == EROFS)
> *mount_flags |= EXT2_MF_READONLY;
>
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2007-10-19 20:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-16 22:37 [PATCH] provide missing mode for open-create in check_mntent_file Eric Sandeen
2007-08-17 17:29 ` Andreas Dilger
2007-10-19 20:15 ` Eric Sandeen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47191068.2010609@redhat.com \
--to=sandeen@redhat.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.