All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hans de Goede <j.w.r.degoede@hhs.nl>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] PATCH: hwmon-abituguru3-new-motherboards.patch
Date: Sat, 20 Oct 2007 22:22:25 +0000	[thread overview]
Message-ID: <471A7FA1.8030703@hhs.nl> (raw)
In-Reply-To: <47190047.6020803@hhs.nl>

Jean Delvare wrote:
> On Sat, 20 Oct 2007 11:47:29 +0200, Jean Delvare wrote:
>> On Fri, 19 Oct 2007 21:06:47 +0200, Hans de Goede wrote:
>>> Hi Mark & All,
>>>
>>> This patch adds support for 2 new motherboards to the abituguru3 driver. Its a 
>>> pretty trivial patch and it would be nice if this could make 2.6.24.
>>>
>>> Signed-of-by: Hans de Goede <j.w.r.degoede@hhs.nl>
>> Acked-by: Jean Delvare <khali@linux-fr.org>
> 
> Err, I take that back. The patch doesn't even build! List terminators
> are missing, and thankfully closing curly braces do as well, otherwise
> I wouldn't have noticed.
> 
> Hans, when you send patches and insist on having them pushed to Linus
> quickly, you should at least make sure they build and don't cause any
> regression on your own system. Obviously you didn't do that this time :(
> 

Oops,

You are fully right, I was doing a zillion things at once, and didn't test 
build this before sending the patch. My bad, aplogies!

I'll do a new version asap.

Regards,

Hans

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

  parent reply	other threads:[~2007-10-20 22:22 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-19 19:06 [lm-sensors] PATCH: hwmon-abituguru3-new-motherboards.patch Hans de Goede
2007-10-20  9:47 ` Jean Delvare
2007-10-20 19:02 ` Jean Delvare
2007-10-20 22:22 ` Hans de Goede [this message]
2007-10-20 22:55 ` [lm-sensors] PATCH: hwmon-abituguru3-new-motherboards-v2.patch Hans de Goede
2007-10-20 22:57 ` [lm-sensors] PATCH: hwmon-abituguru3-new-motherboards.patch Hans de Goede
2007-10-21 18:36 ` [lm-sensors] PATCH: hwmon-abituguru3-new-motherboards-v2.patch Jean Delvare
2007-10-23 11:29 ` Mark M. Hoffman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=471A7FA1.8030703@hhs.nl \
    --to=j.w.r.degoede@hhs.nl \
    --cc=lm-sensors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.