From: Avi Kivity <avi@qumranet.com>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] qemu/hw piix_pci.c
Date: Sun, 21 Oct 2007 09:12:30 +0200 [thread overview]
Message-ID: <471AFBDE.6080706@qumranet.com> (raw)
In-Reply-To: <E1IjL40-0006Um-G0@cvs.savannah.gnu.org>
Thiemo Seufer wrote:
> CVSROOT: /sources/qemu
> Module name: qemu
> Changes by: Thiemo Seufer <ths> 07/10/20 20:36:52
>
> Modified files:
> hw : piix_pci.c
>
> Log message:
> Enable ACPI interrupts, by Igor Lvovsky.
>
> CVSWeb URLs:
> http://cvs.savannah.gnu.org/viewcvs/qemu/hw/piix_pci.c?cvsroot=qemu&r1=1.11&r2=1.12
>
>
IMO this is a bug. The patch enables the ACPI PCI interrupt every time
it is asserted. If this is really needed, this implies that the guest
OS detects some sort of inconsistency and keeps turning the ACPI
interrupt off.
The bug should be addressed instead of worked-around in this way.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2007-10-21 7:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-20 20:36 [Qemu-devel] qemu/hw piix_pci.c Thiemo Seufer
2007-10-21 7:12 ` Avi Kivity [this message]
2007-10-21 22:16 ` Thiemo Seufer
2007-10-22 7:52 ` Igor Lvovsky
2007-10-22 8:26 ` Michael Hanselmann
2007-10-22 9:11 ` Igor Lvovsky
-- strict thread matches above, loose matches on Subject: below --
2008-03-28 22:28 Aurelien Jarno
2007-12-09 23:02 Thiemo Seufer
2007-01-15 17:08 Thiemo Seufer
2006-09-24 19:31 Fabrice Bellard
2006-09-24 18:49 Fabrice Bellard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=471AFBDE.6080706@qumranet.com \
--to=avi@qumranet.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.