From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1Ijagp-0003zo-JI for mharc-grub-devel@gnu.org; Sun, 21 Oct 2007 09:17:59 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Ijagn-0003zc-F7 for grub-devel@gnu.org; Sun, 21 Oct 2007 09:17:57 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Ijagj-0003y0-AQ for grub-devel@gnu.org; Sun, 21 Oct 2007 09:17:56 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ijagj-0003xu-2q for grub-devel@gnu.org; Sun, 21 Oct 2007 09:17:53 -0400 Received: from pne-smtpout3-sn2.hy.skanova.net ([81.228.8.111]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Ijagi-0007Ka-Fv for grub-devel@gnu.org; Sun, 21 Oct 2007 09:17:52 -0400 Received: from [127.0.0.1] (88.193.32.97) by pne-smtpout3-sn2.hy.skanova.net (7.3.129) id 471A569500004E23 for grub-devel@gnu.org; Sun, 21 Oct 2007 15:17:51 +0200 Message-ID: <471B518A.8070607@nic.fi> Date: Sun, 21 Oct 2007 16:18:02 +0300 From: =?ISO-8859-1?Q?Vesa_J=E4=E4skel=E4inen?= User-Agent: Thunderbird 2.0.0.6 (Windows/20070728) MIME-Version: 1.0 To: The development of GRUB 2 References: <1Ihl95-0ez6x60@fwd32.aul.t-online.de> <20071020233721.GA9939@thorin> <471B4EFB.6020009@t-online.de> In-Reply-To: <471B4EFB.6020009@t-online.de> X-Enigmail-Version: 0.95.3 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-detected-kernel: by monty-python.gnu.org: Solaris 10 (beta) Subject: Re: [PATCH] grub2 for Cygwin X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 21 Oct 2007 13:17:57 -0000 Christian Franke wrote: > Robert Millan wrote: >> On Tue, Oct 16, 2007 at 02:03:35PM +0200, Christian Franke wrote: >> Could you send it as an attachment? This way it's easier to comment on >> it contextualy. > I didn't want to send a ~45KB attachment in my first mail to this list ;-) > Patch is attached. I see... Actually this patch has to be splitted to multiple different patches as not all changes seem to be related to Cygwin building. And it makes it much easier to get approved in smaller slices. And for each patch, describe in email why did you made changes related to patch. I see that there are some good changes that should be applied whether it is for cygwin build or not. But lets keep their commenting to single features (patches) :)