From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1IjumG-0006DL-VC
	for qemu-devel@nongnu.org; Mon, 22 Oct 2007 06:44:56 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1IjumE-0006By-Dl
	for qemu-devel@nongnu.org; Mon, 22 Oct 2007 06:44:55 -0400
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1IjumE-0006Bv-5T
	for qemu-devel@nongnu.org; Mon, 22 Oct 2007 06:44:54 -0400
Received: from mu-out-0910.google.com ([209.85.134.189])
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <dor.laor@gmail.com>) id 1IjumD-0000Hn-MW
	for qemu-devel@nongnu.org; Mon, 22 Oct 2007 06:44:53 -0400
Received: by mu-out-0910.google.com with SMTP id w8so1612307mue
	for <qemu-devel@nongnu.org>; Mon, 22 Oct 2007 03:44:52 -0700 (PDT)
Message-ID: <471C7F20.9040805@qumranet.com>
Date: Mon, 22 Oct 2007 12:44:48 +0200
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH, RFC] USB OHCI isochronous transfers support
References: <64F9B87B6B770947A9F8391472E032160E323223@ehost011-8.exch011.intermedia.net>
In-Reply-To: <64F9B87B6B770947A9F8391472E032160E323223@ehost011-8.exch011.intermedia.net>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
From: Dor Laor <dor.laor@gmail.com>
Reply-To: dor.laor@qumranet.com, qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Arnon Gilboa wrote:
>
> Hi,
>
> The attached patch adds isochronous transfers support to the OHCI
> emulation, similarly to the UHCI patch pushed two weeks ago.
>
> In order to use ohci instead of uhci, replace the following line in
> pc.c:
> usb_uhci_piix3_init(pci_bus, piix3_devfn + 2);
>
> With:
> usb_ohci_init_pci(pci_bus, 3, piix3_devfn + 2);
>
> Any comments?
>
What about making it dynamically set by cmdline?
Dor