From: John Belmonte <john@neggie.net>
To: Jonathan McDowell <noodles@earth.li>
Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Add bluetooth support to toshiba-acpi driver
Date: Mon, 22 Oct 2007 07:26:26 -0400 [thread overview]
Message-ID: <471C88E2.3020102@neggie.net> (raw)
In-Reply-To: <20071021173529.GH1880@earth.li>
> This patch adds bluetooth support to the toshiba-acpi driver. I have
> tried to follow the same format for the /proc/acpi/toshiba/bluetooth
> file as followed in the thinkpad-acpi driver. In the long term the
> rfkill infrastructure looks like the way forward for this functionality,
> but at present it doesn't seem to be suitable.
>
> Traditionally the userland "toshset" program would have been used to
> enable bluetooth, but this requires either CONFIG_TOSHIBA or a patched
> toshiba-acpi to emulate the /dev/toshiba device. Also toshset doesn't
> currently run in 64bit mode.
>
> Patch has been successfully tested on a Portégé R200 (in 32bit mode) and
> an R500 (in 64bit mode).
>
> Signed-Off-By: Jonathan McDowell <noodles@earth.li>
The /proc/acpi/toshiba interface should not be expanded-- do not apply
this patch. If any patch is applied, it would be to optionally
implement the generic /dev/toshiba interface so that user space tools
like toshset can operate.
--John Belmonte
-
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: John Belmonte <john@neggie.net>
To: Jonathan McDowell <noodles@earth.li>
Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Add bluetooth support to toshiba-acpi driver
Date: Mon, 22 Oct 2007 07:26:26 -0400 [thread overview]
Message-ID: <471C88E2.3020102@neggie.net> (raw)
In-Reply-To: <20071021173529.GH1880@earth.li>
> This patch adds bluetooth support to the toshiba-acpi driver. I have
> tried to follow the same format for the /proc/acpi/toshiba/bluetooth
> file as followed in the thinkpad-acpi driver. In the long term the
> rfkill infrastructure looks like the way forward for this functionality,
> but at present it doesn't seem to be suitable.
>
> Traditionally the userland "toshset" program would have been used to
> enable bluetooth, but this requires either CONFIG_TOSHIBA or a patched
> toshiba-acpi to emulate the /dev/toshiba device. Also toshset doesn't
> currently run in 64bit mode.
>
> Patch has been successfully tested on a Portégé R200 (in 32bit mode) and
> an R500 (in 64bit mode).
>
> Signed-Off-By: Jonathan McDowell <noodles@earth.li>
The /proc/acpi/toshiba interface should not be expanded-- do not apply
this patch. If any patch is applied, it would be to optionally
implement the generic /dev/toshiba interface so that user space tools
like toshset can operate.
--John Belmonte
next prev parent reply other threads:[~2007-10-22 11:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-21 17:35 [PATCH] Add bluetooth support to toshiba-acpi driver Jonathan McDowell
2007-10-21 17:35 ` Jonathan McDowell
2007-10-22 2:30 ` Andrey Borzenkov
2007-10-22 8:11 ` Jonathan McDowell
2007-10-22 11:26 ` John Belmonte [this message]
2007-10-22 11:26 ` John Belmonte
2007-10-22 14:28 ` Jonathan McDowell
2007-10-22 14:54 ` Matthew Garrett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=471C88E2.3020102@neggie.net \
--to=john@neggie.net \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=noodles@earth.li \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.