From: Benny Halevy <bhalevy@panasas.com>
To: Matthew Wilcox <matthew@wil.cx>
Cc: Boaz Harrosh <bharrosh@panasas.com>,
James Bottomley <James.Bottomley@SteelEye.com>,
Hannes Reinecke <hare@suse.de>,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH 4/4] aic7xxx: Enable 16-bit CDBs
Date: Mon, 22 Oct 2007 23:24:49 +0200 [thread overview]
Message-ID: <471D1521.3090405@panasas.com> (raw)
In-Reply-To: <20071022193551.GF27248@parisc-linux.org>
On Oct. 22, 2007, 21:35 +0200, Matthew Wilcox <matthew@wil.cx> wrote:
> On Mon, Oct 22, 2007 at 09:10:49PM +0200, Boaz Harrosh wrote:
>> I'm about to finish an RFC patchset for the extended commands.
>> I have implemented a more aggressive approach than the one
>> I've been sending for the last year.
>> (Matthew I have an extra 8-bytes save to scsi_cmnd on
>> 64bit and 12 bytes for 32bit. Guess how? ;))
>
> Well ... the command has to be stored somewhere. If it's an additional
> kmalloc, that's a loss. If it's in the request, that's a loss too ...
> let's see where you're keeping it ;-)
>
I love spoiling Boaz's surprise :)
The gist of it is scsi_cmnd->cmnd pointing at req->cmd
or at req->varlen_cmd as appropriate.
Most users can't tell the difference except if they
tried using sizeof(scsi_cmnd->cmnd) in which case they
can use MAX_COMMAND_SIZE instead.
Benny
prev parent reply other threads:[~2007-10-22 21:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-19 8:32 [PATCH 4/4] aic7xxx: Enable 16-bit CDBs Hannes Reinecke
2007-10-21 16:19 ` James Bottomley
2007-10-22 3:46 ` Matthew Wilcox
2007-10-22 6:50 ` Hannes Reinecke
2007-10-22 11:23 ` Matthew Wilcox
2007-10-22 11:57 ` Hannes Reinecke
2007-10-23 16:56 ` James Bottomley
2007-10-25 6:31 ` Hannes Reinecke
2007-10-22 19:10 ` Boaz Harrosh
2007-10-22 19:35 ` Matthew Wilcox
2007-10-22 21:24 ` Benny Halevy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=471D1521.3090405@panasas.com \
--to=bhalevy@panasas.com \
--cc=James.Bottomley@SteelEye.com \
--cc=bharrosh@panasas.com \
--cc=hare@suse.de \
--cc=linux-scsi@vger.kernel.org \
--cc=matthew@wil.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.