All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Sixt <j.sixt@viscovery.net>
To: Christian Couder <chriscool@tuxfamily.org>
Cc: Pierre Habouzit <madcoder@debian.org>,
	"Shawn O. Pearce" <spearce@spearce.org>,
	git@vger.kernel.org
Subject: Re: [PATCH] Add some fancy colors in the test library when terminal supports it.
Date: Tue, 23 Oct 2007 08:37:43 +0200	[thread overview]
Message-ID: <471D96B7.4080200@viscovery.net> (raw)
In-Reply-To: <200710230608.15124.chriscool@tuxfamily.org>

Christian Couder schrieb:
> Anyway, perhaps having:
> 
> _red=1
> _green=2
> 
> and then using "say_color $_red stuff" might be easier to understand and 
> change if needed.

Good idea. But then better name it by its purpose:

fail=1	# red
pass=2	# green

-- Hannes

  reply	other threads:[~2007-10-23  6:38 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-22  8:13 [PATCH] Add some fancy colors in the test library when terminal supports it Pierre Habouzit
2007-10-22  8:53 ` Johannes Sixt
2007-10-22 11:24   ` Pierre Habouzit
2007-10-22 11:35     ` Johannes Sixt
2007-10-22 12:11       ` Pierre Habouzit
2007-10-22 12:18         ` Johannes Sixt
2007-10-22 13:45           ` Pierre Habouzit
2007-10-23  4:08 ` Christian Couder
2007-10-23  6:37   ` Johannes Sixt [this message]
2007-10-23  8:13   ` Pierre Habouzit
  -- strict thread matches above, loose matches on Subject: below --
2007-10-24 20:03 Small enhancements of the test-lib.sh Pierre Habouzit
     [not found] ` <1193256219-24222-2-git-send-email-madcoder@debian.org>
2007-10-24 20:28   ` [PATCH] Add some fancy colors in the test library when terminal supports it Pierre Habouzit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=471D96B7.4080200@viscovery.net \
    --to=j.sixt@viscovery.net \
    --cc=chriscool@tuxfamily.org \
    --cc=git@vger.kernel.org \
    --cc=madcoder@debian.org \
    --cc=spearce@spearce.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.