From: Jeff Garzik <jeff@garzik.org>
To: David Miller <davem@davemloft.net>
Cc: barkalow@iabervon.org, linas@austin.ibm.com,
chunhao.huang@hotmail.com, gregkh@suse.de, htejun@gmail.com,
brice.goglin@gmail.com, david.gaarenstroom@gmail.com,
linux-kernel@vger.kernel.org, linux-pci@atrey.karlin.mff.cuni.cz,
shane.huang@amd.com, linux-ide@vger.kernel.org, brice@myri.com
Subject: Re: [patch] PCI: disable MSI on more ATI NorthBridges
Date: Tue, 23 Oct 2007 06:01:17 -0400 [thread overview]
Message-ID: <471DC66D.6000909@garzik.org> (raw)
In-Reply-To: <20071022.171318.104036671.davem@davemloft.net>
David Miller wrote:
> My suggestion is:
>
> 1) Leave the pci_intx() twiddling code in drivers/pci/msi.c
>
> 2) Add quirks for "INTX_DISABLE turns off MSI too", this sets
> a flag in the pci_dev.
>
> 3) The pci_intx() calls in drivers/pci/msi.c are skipped if this
> flag from #2 is set.
>
> 4) Add quirk entries for drivers/net/tg3.c chips and these SATA
> devices we are learning about here, as well as any others we
> are aware of right now.
>
> 5) Remove the pci_intx() workaround code from drivers/net/tg3.c
> and elsewhere.
Sounds good to me also.
Jeff
next prev parent reply other threads:[~2007-10-23 10:01 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-19 13:17 [patch] PCI: disable MSI on more ATI NorthBridges Shane Huang
[not found] ` <9783dadb0710190706i499b4edbh9736019b0384f9b1@mail.gmail.com>
2007-10-19 14:10 ` Fwd: " David Gaarenstroom
2007-10-19 19:57 ` Linas Vepstas
2007-10-19 20:21 ` Jeff Garzik
2007-10-20 22:03 ` Benjamin Herrenschmidt
2007-10-22 20:26 ` Daniel Barkalow
2007-10-22 20:41 ` Jeff Garzik
2007-10-22 21:31 ` Daniel Barkalow
2007-10-22 23:48 ` Krzysztof Halasa
2007-10-23 0:13 ` David Miller
2007-10-23 5:52 ` Daniel Barkalow
2007-10-23 9:39 ` Shane Huang
2007-10-23 10:01 ` Jeff Garzik [this message]
2007-10-23 10:06 ` David Miller
2007-10-24 2:46 ` David Miller
2007-10-23 10:15 ` Jeff Garzik
2007-10-22 23:40 ` Krzysztof Halasa
2007-10-22 23:58 ` David Miller
2007-10-23 10:13 ` Jeff Garzik
2007-10-20 14:50 ` Shane Huang
2007-10-20 14:50 ` Shane Huang
2007-10-20 20:52 ` David Gaarenstroom
2007-10-21 6:00 ` Shane Huang
2007-10-23 10:56 ` Shane Huang
2007-10-24 2:41 ` David Miller
2007-10-24 6:53 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2007-10-18 9:14 Shane Huang
2007-10-18 10:19 ` David Miller
2007-10-18 10:37 ` Shane Huang
2007-10-18 11:46 ` David Miller
2007-10-18 15:24 ` Greg KH
2007-10-19 17:42 ` Daniel Barkalow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=471DC66D.6000909@garzik.org \
--to=jeff@garzik.org \
--cc=barkalow@iabervon.org \
--cc=brice.goglin@gmail.com \
--cc=brice@myri.com \
--cc=chunhao.huang@hotmail.com \
--cc=davem@davemloft.net \
--cc=david.gaarenstroom@gmail.com \
--cc=gregkh@suse.de \
--cc=htejun@gmail.com \
--cc=linas@austin.ibm.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@atrey.karlin.mff.cuni.cz \
--cc=shane.huang@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.