From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1IkQUn-0001XT-KY for mharc-grub-devel@gnu.org; Tue, 23 Oct 2007 16:37:01 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IkQUl-0001WM-QR for grub-devel@gnu.org; Tue, 23 Oct 2007 16:36:59 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IkQUg-0001WA-DX for grub-devel@gnu.org; Tue, 23 Oct 2007 16:36:58 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IkQUg-0001W7-89 for grub-devel@gnu.org; Tue, 23 Oct 2007 16:36:54 -0400 Received: from mailout02.sul.t-online.de ([194.25.134.17] helo=mailout02.sul.t-online.com) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1IkQUf-0000Zv-Un for grub-devel@gnu.org; Tue, 23 Oct 2007 16:36:54 -0400 Received: from fwd34.aul.t-online.de by mailout02.sul.t-online.com with smtp id 1IkQUe-0002uM-06; Tue, 23 Oct 2007 22:36:52 +0200 Received: from [10.3.2.2] (bHPwM0ZVwhlw9IS76IgvXdkJWVHVDT5DzZnbAsNW+X4SHCvdEDG2pNTqEeC5IDCQ2A@[217.235.205.199]) by fwd34.aul.t-online.de with esmtp id 1IkQUS-0Y0Z1M0; Tue, 23 Oct 2007 22:36:40 +0200 Message-ID: <471E5B5B.4020307@t-online.de> Date: Tue, 23 Oct 2007 22:36:43 +0200 From: Christian Franke User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.6) Gecko/20070802 SeaMonkey/1.1.4 MIME-Version: 1.0 To: The development of GRUB 2 References: <471E4628.9030706@t-online.de> <20071023201840.GB29047@thorin> In-Reply-To: <20071023201840.GB29047@thorin> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-ID: bHPwM0ZVwhlw9IS76IgvXdkJWVHVDT5DzZnbAsNW+X4SHCvdEDG2pNTqEeC5IDCQ2A X-TOI-MSGID: 33c6edad-b004-4e07-9401-65b10a8aaedf X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 3) Subject: Re: [PATCH] Fix eisa_mmap evaluation, add memory existence check X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Oct 2007 20:36:59 -0000 Robert Millan wrote: > On Tue, Oct 23, 2007 at 09:06:16PM +0200, Christian Franke wrote: > >> This patch fixes the broken evaluation of the E801 EISA memory map. The >> shift was too much, the high word is already shifted :-) The bug was >> hidden until the E820 memory map evaluation was broken due to the struct >> packing issue fixed in my last patch. >> >> The extra handling of "0x3C00" case is IMO not necessary. Regions are >> merged a few lines later. >> >> During testing, I added a primitive memory to detect such problems >> early. It was difficult to find why grub crashes during module load. >> > > Is this related to Cygwin? > > No. The EISA memory map bug would crash GRUB on all systems w/o E820 memory map support. The memory existence test is not necessary of course, but helped to check that memory map evaluation was finally working properly. Christian