From: Jeremy Fitzhardinge <jeremy@goop.org>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: "Huang, Ying" <ying.huang@intel.com>, Andi Kleen <ak@suse.de>,
"Eric W. Biederman" <ebiederm@xmission.com>,
akpm@linux-foundation.org,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH -v7 1/3] x86 boot: setup data
Date: Tue, 23 Oct 2007 16:26:51 -0700 [thread overview]
Message-ID: <471E833B.6070602@goop.org> (raw)
In-Reply-To: <471E7B1D.4050107@zytor.com>
H. Peter Anvin wrote:
> Furthermore, on looking through the code again, I see a bunch of
> "init_pg_tables_end + setup_data_len" which really is ugly.
Yeah, that's what I'm objecting to.
>> What are the alignment rules for this structure? Is it always 64-bit
>> aligned? What about the relationship of len and data?
>>
>
> It's x86, so alignment is soft - it presumably *should* be 64-bit
> aligned, but nothing break if the boot loader doesn't.
This was more or less a rhetorical question - the code spends some
effort in rounding len up to some alignment, so its probably worth
documenting with the structure.
J
next prev parent reply other threads:[~2007-10-23 23:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-23 8:06 [PATCH -v7 1/3] x86 boot: setup data Huang, Ying
2007-10-23 22:08 ` Jeremy Fitzhardinge
2007-10-23 22:15 ` H. Peter Anvin
2007-10-23 22:20 ` Jeremy Fitzhardinge
2007-10-23 22:32 ` H. Peter Anvin
2007-10-23 22:52 ` H. Peter Anvin
2007-10-23 23:26 ` Jeremy Fitzhardinge [this message]
2007-10-23 23:18 ` Andi Kleen
2007-10-23 23:55 ` H. Peter Anvin
2007-10-24 3:08 ` Huang, Ying
2007-10-24 22:48 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=471E833B.6070602@goop.org \
--to=jeremy@goop.org \
--cc=ak@suse.de \
--cc=akpm@linux-foundation.org \
--cc=ebiederm@xmission.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.