From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Jeff Garzik <jeff@garzik.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
akpm@linux-foundation.org, tglx@linutronix.de
Subject: Re: [PATCH 2/12] X86: fix nvidia HPET warning
Date: Tue, 23 Oct 2007 21:05:34 -0700 [thread overview]
Message-ID: <471EC48E.2080506@goop.org> (raw)
In-Reply-To: <20071023223635.24CE01F81A1@havoc.gtf.org>
Jeff Garzik wrote:
> arch/x86/kernel/early-quirks.c:40: warning: ‘nvidia_hpet_check’ defined but not used
>
> Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
> ---
>
> diff --git a/arch/x86/kernel/early-quirks.c b/arch/x86/kernel/early-quirks.c
> index dc34acb..639e632 100644
> --- a/arch/x86/kernel/early-quirks.c
> +++ b/arch/x86/kernel/early-quirks.c
> @@ -35,12 +35,14 @@ static void __init via_bugs(void)
> }
>
> #ifdef CONFIG_ACPI
> +#ifdef CONFIG_X86_IO_APIC
>
Why not #if defined(CONFIG_ACPI) && defined(CONFIG_X86_IO_APIC)? Saves
a line and a layer of #if(def).
>
> static int __init nvidia_hpet_check(struct acpi_table_header *header)
> {
> return 0;
> }
> -#endif
> +#endif /* CONFIG_X86_IO_APIC */
> +#endif /* CONFIG_ACPI */
>
J
next prev parent reply other threads:[~2007-10-24 4:05 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-23 22:36 [PATCH 1/12] X86: fix !CONFIG_SMP warning in processor.c Jeff Garzik
2007-10-23 22:36 ` [PATCH 2/12] X86: fix nvidia HPET warning Jeff Garzik
2007-10-24 4:05 ` Jeremy Fitzhardinge [this message]
2007-10-24 6:05 ` Jeff Garzik
2007-10-24 12:03 ` Ingo Molnar
2007-10-23 22:36 ` [PATCH 3/12] ACPI sbs: fix retval warning Jeff Garzik
2007-10-30 10:31 ` Jeff Garzik
2007-10-23 22:36 ` [PATCH 4/12] riscom8: fix SMP brokenness Jeff Garzik
2007-10-24 6:47 ` Jiri Slaby
2007-10-24 6:52 ` Jeff Garzik
2007-10-24 7:44 ` Jiri Slaby
2007-10-24 7:10 ` Andrew Morton
2007-10-24 7:44 ` Jiri Slaby
2007-10-24 8:00 ` Andrew Morton
2008-02-07 0:29 ` [bug] " Ingo Molnar
2008-02-20 20:37 ` Jeff Garzik
2008-02-20 22:00 ` Alan Cox
2007-10-23 22:36 ` [PATCH 5/12] ISDN/sc: fix longstanding warning Jeff Garzik
2007-10-24 7:24 ` Karsten Keil
2007-10-23 22:36 ` [PATCH 6/12] KVM: work around SMP requirement Jeff Garzik
2007-10-23 22:44 ` Adrian Bunk
2007-10-23 22:46 ` Jeff Garzik
2007-10-24 8:36 ` Avi Kivity
2007-10-24 12:32 ` [patch] kvm: fix !SMP build error Ingo Molnar
2007-10-24 12:36 ` Ingo Molnar
2007-10-24 18:11 ` Ingo Molnar
2007-11-01 3:34 ` Randy Dunlap
2007-11-01 8:31 ` Ingo Molnar
2007-11-01 13:10 ` Avi Kivity
2007-11-01 14:59 ` Ingo Molnar
2007-11-01 21:16 ` Avi Kivity
2007-10-23 22:36 ` [PATCH 7/12] eexpress: fix !SMP unused-var warning Jeff Garzik
2007-10-23 22:36 ` [PATCH 8/12] ni5010: kill unused variable Jeff Garzik
2007-10-23 22:36 ` [PATCH 9/12] cgroup: " Jeff Garzik
2007-10-24 0:19 ` Paul Menage
2007-10-23 22:36 ` [PATCH 10/12] mac80211: fix warning created by BIT() Jeff Garzik
2007-10-23 22:36 ` Jeff Garzik
2007-10-23 23:15 ` Randy Dunlap
2007-10-23 23:15 ` Randy Dunlap
2007-10-23 22:36 ` [PATCH 11/12] NET: fix subqueue bugs Jeff Garzik
2007-10-23 22:36 ` Jeff Garzik
2007-10-23 22:38 ` David Miller
2007-10-23 22:40 ` Jeff Garzik
2007-10-23 22:36 ` [PATCH 12/12] sound/isa: fix printk format Jeff Garzik
2007-10-24 4:03 ` [PATCH 1/12] X86: fix !CONFIG_SMP warning in processor.c Jeremy Fitzhardinge
2007-10-24 12:01 ` Ingo Molnar
2007-10-24 16:27 ` [2.6 patch] x86/kernel/acpi/processor.c: fix SMP=n warning Adrian Bunk
2007-10-24 16:27 ` Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=471EC48E.2080506@goop.org \
--to=jeremy@goop.org \
--cc=akpm@linux-foundation.org \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.