All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Timo Teräs" <timo.teras@iki.fi>
To: Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>
Cc: Patrick McHardy <kaber@trash.net>,
	davem@davemloft.net, netdev@vger.kernel.org
Subject: Re: [PATCH RESEND] ip_gre: sendto/recvfrom NBMA address
Date: Wed, 24 Oct 2007 08:54:42 +0300	[thread overview]
Message-ID: <471EDE22.4090408@iki.fi> (raw)
In-Reply-To: <20071023202036.GA12066@ms2.inr.ac.ru>

Hi,

Alexey Kuznetsov wrote:
>> The only dubious case is when next hop is set using routing tables.
>> But code in ipgre_tunnel_xmit() is ready to accept this situation,
>> it checks for zero destination address and fixes it when it is able to.
> 
> Nevertheless, it does not work.
> 
> Another thoughts?

Could you explain this a little more?

I was able to set a nbma gre tunnel, add routes to it and it worked
perfectly ok.

Link-level next hop worked:
ip route add <route> via <link-level-address> dev <tunnel-dev> onlink

Also normal route with static neighbor worked:
ip neigh add <router-tunnel-ip> lladdr <link-level-address> nud permanent dev <tunnel-dev>
ip route add <route> via <router-tunnel-ip>

In both cases packets were routed as expected to hosts accessible using
the added route. And sendto() sent a packet correctly with destination
link-level-address set. Did I miss/misunderstand something?

Cheers,
  Timo

  reply	other threads:[~2007-10-24  5:54 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-23 14:31 [PATCH RESEND] ip_gre: sendto/recvfrom NBMA address Timo Teräs
2007-10-23 14:33 ` Patrick McHardy
2007-10-23 15:08   ` Timo Teräs
2007-10-23 15:57   ` Timo Teräs
2007-10-23 16:10     ` Patrick McHardy
2007-10-23 19:03     ` Alexey Kuznetsov
2007-10-24  3:32       ` David Miller
2007-10-23 20:20     ` Alexey Kuznetsov
2007-10-24  5:54       ` Timo Teräs [this message]
2007-10-24 10:08         ` Alexey Kuznetsov
2007-12-18 13:59           ` [RFC][PATCH][IPV4] ip_gre: use skb->{mac,network}_header consistently Timo Teräs
2007-12-19 18:10             ` [PATCH][IPV4] ip_gre: set mac_header correctly in receive path Timo Teräs
2007-12-20  8:11               ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=471EDE22.4090408@iki.fi \
    --to=timo.teras@iki.fi \
    --cc=davem@davemloft.net \
    --cc=kaber@trash.net \
    --cc=kuznet@ms2.inr.ac.ru \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.