All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jeff@garzik.org>
To: Andi Kleen <ak@suse.de>
Cc: linux-kernel@vger.kernel.org, akpm@osdl.org,
	shannon.nelson@intel.com, anil.s.keshavamurthy@intel.com
Subject: Re: [PATCH] Remove bogus default y for DMAR and NET_DMA
Date: Wed, 24 Oct 2007 05:24:20 -0400	[thread overview]
Message-ID: <471F0F44.4010102@garzik.org> (raw)
In-Reply-To: <200710241112.39451.ak@suse.de>

Andi Kleen wrote:
> Index: linux-2.6.24-rc1-hack/arch/x86_64/Kconfig
> ===================================================================
> --- linux-2.6.24-rc1-hack.orig/arch/x86_64/Kconfig
> +++ linux-2.6.24-rc1-hack/arch/x86_64/Kconfig
> @@ -753,7 +753,6 @@ config PCI_DOMAINS
>  config DMAR
>  	bool "Support for DMA Remapping Devices (EXPERIMENTAL)"
>  	depends on PCI_MSI && ACPI && EXPERIMENTAL
> -	default y
>  	help
>  	  DMA remapping (DMAR) devices support enables independent address
>  	  translations for Direct Memory Access (DMA) from devices.

ACK


> Index: linux-2.6.24-rc1-hack/drivers/dma/Kconfig
> ===================================================================
> --- linux-2.6.24-rc1-hack.orig/drivers/dma/Kconfig
> +++ linux-2.6.24-rc1-hack/drivers/dma/Kconfig
> @@ -43,7 +43,6 @@ comment "DMA Clients"
>  config NET_DMA
>  	bool "Network: TCP receive copy offload"
>  	depends on DMA_ENGINE && NET
> -	default y
>  	help
>  	  This enables the use of DMA engines in the network stack to
>  	  offload receive copy-to-user operations, freeing CPU cycles.

ACK -- but its arguable that given the current code, its worth setting 
this if DMA_ENGINE is also set.


  reply	other threads:[~2007-10-24  9:24 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-24  9:12 [PATCH] Remove bogus default y for DMAR and NET_DMA Andi Kleen
2007-10-24  9:24 ` Jeff Garzik [this message]
2007-10-24 15:28   ` Nelson, Shannon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=471F0F44.4010102@garzik.org \
    --to=jeff@garzik.org \
    --cc=ak@suse.de \
    --cc=akpm@osdl.org \
    --cc=anil.s.keshavamurthy@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=shannon.nelson@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.