Re: [Xenomai-core] I-pipe fasteoi interrupt handling issue

[Philippe Gerum <rpm@xenomai.org>]

Jeroen Van den Keybus wrote:
> On my Linux 2.6.23 with latest I-pipe patch (1.10-10), interrupts are
> dispatched twice if they are of the fasteoi type.
>  
> I have the impression that the I-pipe does the eoi() acknowledgement (in
> kernel/irq/chip.c: __ipipe_ack_fasteoi_irq) without first masking off
> the IRQ. As the interrupt line hasn't been cleared at this time, the
> interrupt is immediately reissued.

Does this help?

--- arch/i386/kernel/io_apic.c~	2007-10-22 16:43:21.000000000 +0200
+++ arch/i386/kernel/io_apic.c	2007-10-24 15:24:16.000000000 +0200
@@ -1985,6 +1985,17 @@
  * operation to prevent an edge-triggered interrupt escaping meanwhile.
  * The idea is from Manfred Spraul.  --macro
  */
+
+#ifdef CONFIG_IPIPE
+/*
+ * Prevent low priority IRQs grabbed by high priority domains from
+ * being delayed, waiting for a high priority interrupt handler
+ * running in a low priority domain to complete.
+ */
+	spin_lock(&ioapic_lock);
+	__mask_IO_APIC_irq(irq);
+	spin_unlock(&ioapic_lock);
+#endif
 	i = irq_vector[irq];

 	v = apic_read(APIC_TMR + ((i & ~0x1f) >> 1));
@@ -1998,17 +2009,6 @@
 		__unmask_and_level_IO_APIC_irq(irq);
 		spin_unlock(&ioapic_lock);
 	}
-
-#ifdef CONFIG_IPIPE
-/*
- * Prevent low priority IRQs grabbed by high priority domains from
- * being delayed, waiting for a high priority interrupt handler
- * running in a low priority domain to complete.
- */
-	spin_lock(&ioapic_lock);
-	__mask_IO_APIC_irq(irq);
-	spin_unlock(&ioapic_lock);
-#endif
 }

-- 
Philippe.